feat: add support for authorization parameters and ensure state param is included from query when present in Facebook & Microsoft OAuth #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates - Added support for the `state` parameter in the Facebook OAuth configuration. - The `state` parameter is now included in the runtime configuration under `oauth.facebook`. - Encoded the `state` parameter as a JSON string to allow custom data to be passed (e.g., redirect subdomain).
commit: |
- Removed unnecessary `JSON.stringify` as `config.state` is expected to be a string. - Simplified the conditional check to include `state` only if it is truthy. - Ensured the `state` parameter is URL-encoded for safety.
mendrinos
changed the title
mendrinos
changed the title
mendrinos
changed the title
atinux
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateparameter in the Facebook OAuth configuration.stateparameter as a JSON string to allow custom data to be passed (e.g., redirect subdomain).