remove buffer from src/hdr buffer list if the buffer is killed #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
3 similar comments
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
|
Looks good, but could you add a test please? I don't want a regression for this to be introduced. |
|
@atilaneves If you give me some more time I can write some test for that (maybe around late august). It could be that i need ert-async since i need to wait until cmake is successfully run |
|
@0x17de Sure, it's your fix, so whenever you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the buffer was killed it should be removed from the list of source and header buffers; Otherwise a new call to
cmake-ide-run-cmakewill cause minor issues since the file is closed while trying to apply new flags.