Move "TargetFrameworkMonikerAssemblyAttributesPath" into "Directory.B…

…uild.targets" Per following suggestion by @tmat > Setting `TargetFrameworkMonikerAssemblyAttributesPath` needs to be > done after importing SDK targets because `IntermediateOutputPath` is > set in `Microsoft.Common.CurrentVersion.targets` and not before that. > > So I think the best would be to set it in `Directory.Build.targets` > in the repo root. Source: shiftkey/dotnetcore-sourcelink-test-bug#1 (comment)
atifaziz · Apr 8, 2020 · 91f6566 · 91f6566
1 parent 8aca8d9
commit 91f6566
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Directory.Build.targets b/Directory.Build.targets
@@ -0,0 +1,5 @@
+<Project>
+  <PropertyGroup>
+    <TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)', '$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath>
+  </PropertyGroup>
+</Project>
diff --git a/src/Fizzler.Systems.HtmlAgilityPack.csproj b/src/Fizzler.Systems.HtmlAgilityPack.csproj
@@ -33,7 +33,6 @@
   </ItemGroup>
   <PropertyGroup>
     <EmbedUntrackedSource>true</EmbedUntrackedSource>
-    <TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)', '$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath>
   </PropertyGroup>
   <ItemGroup>
     <EmbeddedFiles Include="$(GeneratedAssemblyInfoFile)"/>