refactor context menus #2302
Merged
refactor context menus #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tangjeff0
requested changes
Aug 22, 2022
| @@ -362,7 +362,7 @@ | |||
| reactions (and reactions-enabled? | |||
| (block-reaction/props->reactions properties)) | |||
| menu (r/as-element | |||
| [:> MenuList {:class "anchor"} | |||
There was a problem hiding this comment.
The menu items need to have an .anchor class as a parent, otherwise, multiple block selection gets cleared when trying to click one of the buttons. #2296
tangjeff0
requested changes
Aug 22, 2022
| @@ -362,7 +362,18 @@ | |||
| reactions (and reactions-enabled? | |||
| (block-reaction/props->reactions properties)) | |||
| menu (r/as-element | |||
| [:<> | |||
| [:> MenuGroup {:className ".anchor"} | |||
There was a problem hiding this comment.
Copying multiple block refs or text from multiple selected blocks only copies from one. Class name might need to be anchor, not .anchor.
tangjeff0
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major
Minor