Add generated_by parameter to newly created Files
#832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athackst
reviewed
Mar 26, 2025
Owner
athackst
left a comment
athackst
left a comment
There was a problem hiding this comment.
I can add the generated_by to the file after construction instead, since it looks like it's erroring out on construction.
mkdocs_simple_plugin/plugin.py
Outdated
| dest_dir=config.site_dir, | ||
| use_directory_urls=config["use_directory_urls"] | ||
| use_directory_urls=config["use_directory_urls"], | ||
| generated_by="mkdocs_simple_plugin", |
Owner
There was a problem hiding this comment.
It doesn't look like this is a part of the constructor
athackst
reviewed
Mar 26, 2025
athackst
reviewed
Mar 26, 2025
Oof, I'm having trouble with the web interface.
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/mkdocs/mkdocs/blob/4c7404485f988f409ccaf42fefe705222ff5965a/mkdocs/structure/files.py#L238C5-L238C17
This help with compatibility with other plugins that use
gitinformation