-
Notifications
You must be signed in to change notification settings - Fork 10
Support dirtyreload so that only updated files get rebuilt #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ec80f4c to
9f1f6b8
Compare
|
Hey there - just had a chance to give this a try this morning. Unfortunately from what I'm seeing, I think all files may still be getting rebuilt (or perhaps I'm misunderstanding how this is meant to work). Running the first time, I see this as expected: I can then browse docs as usual. Upon changing a file, I see this: But the build doesn't appear to proceed and the site ends up hung (seemingly permanently). |
|
It did eventually rebuild, but took a very long time. Much longer than I remember from last week! |
|
hmm.. I think I didn't keep the venv ignore setting you had which is probably resulting in your setup not working correctly. I added common folders to .mkdocsignore so that they wouldn't be included in a rebuild. Try again? |
|
Gave that a try with the same result. The test I'm running for this is on our production repository using a system-level installation of the plugin, so I don't think any of the in-repo files here would have an effect. The list of files that the plugin says it's watching seems to be correct so far as I can tell (our repo is quite large, so it's hard to be sure, but I haven't noticed anything that seems off). I'm going to give this another try a bit later after tossing a few prints in so that we can see what's going on. The fact that it takes longer to re-generate than it does to generate from scratch makes me think that there is something "recursive" going on, so it's also very possible that this is an issue with the way that I have things set up. Will report back! |
|
Facepalm. I cloned the repo and installed it locally, but didn't check out the feature branch before doing so 🤦 Everything seems to be working perfectly, sorry about that! |
|
I'm going to close #442 in lieu of this |
|
Cool! Good to here. I'll merge in then 😄 |
|
Awesome! Is there anywhere I can follow to see when this makes it into a release? |
|
You can go to watch -> custom -> releases on the repo and you should get an alert when the next release is made 🚀 |
Co-authored-by: @jkaye2012
Closes #441