Skip to content

Change alias access from dockerfile to filesystem mount #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
athackst merged 1 commit into from
Dec 4, 2022
Merged

Change alias access from dockerfile to filesystem mount #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ RUN apt-get update \
# Ruby for html-proofer
&& apt-get install -y --no-install-recommends ruby ruby-dev \
&& gem install html-proofer \
# git settings
&& apt-get install -y --no-install-recommends wget \
&& wget -O /etc/profile.d/git_aliases.sh https://github.com/athackst/workstation_setup/raw/main/user/.aliases/git_aliases.sh \
&& echo "source /etc/profile.d/git_aliases.sh" >> /home/vscode/.bashrc \
# Clean up
&& apt-get autoremove -y \
&& apt-get clean -y \
Expand Down
10 changes: 7 additions & 3 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
// https://github.com/microsoft/vscode-dev-containers/tree/v0.155.1/containers/python-3
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/python
{
"name": "Python 3",
"build": {
Expand All @@ -13,6 +13,11 @@
"remoteEnv": {
"PATH":"${containerEnv:PATH}:/home/vscode/.local/bin"
},
// Mount local aliases if any
"mounts": [
"source=/${env:HOME}/.bash_aliases,target=/home/vscode/.bash_aliases,type=bind,consistency=cached",
"source=/${env:HOME}/.aliases,target=/home/vscode/.aliases,type=bind,consistency=cached"
],
// Set *default* container specific settings.json values on container create.
"settings": {
"terminal.integrated.defaultProfile.linux": "bash",
Expand All @@ -30,7 +35,6 @@
"python.linting.pylintPath": "/usr/local/py-utils/bin/pylint",
"python.testing.pytestPath": "/usr/local/py-utils/bin/pytest"
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": [
"ms-python.python",
Expand Down