Kinetic: minimal changes for compiling on ROS Kinetic (#5) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration from Indigo Eigen interface Force use of OpenCV2 interfaces Add explicit dependency on libopencv-dev, replacing the cv_bridge dependency needed for Indigo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from Indigo Eigen interface
Force use of OpenCV2 interfaces
Add explicit dependency on libopencv-dev,
replacing the cv_bridge dependency needed for Indigo.
These changes should not be merged into
master, they will break the Indigo version. I'd recommend creating akineticbranch, and merging them there.It builds, but with some ugly compiler warnings about deprecated Eigen interfaces.
It runs the opencv_test, displaying a black window with two white dots. I lack the means and expertise for more testing.