Create variablethinmultipole#1095
Merged
Merged
Conversation
Contributor
Author
|
Dear all, who could review this change this PR ? |
swhite2401
reviewed
Jul 8, 2026
swhite2401
left a comment
swhite2401
left a comment
Contributor
There was a problem hiding this comment.
I just had one comment, see code review. The rest seems fine to me.
oscarxblanco
commented
Jul 8, 2026
swhite2401
reviewed
Jul 8, 2026
swhite2401
reviewed
Jul 8, 2026
Contributor
Author
|
Dear @swhite2401 , is there anything else to change ? |
swhite2401
approved these changes
Jul 8, 2026
swhite2401
left a comment
swhite2401
left a comment
Contributor
There was a problem hiding this comment.
Fine for me! Do you want to wait for @lfarv's review? I think he is away for some time...
Contributor
Author
|
I would prefer to merge now, if you agree. |
Contributor
|
Sure I leave the branch alive then in @lfarv wnats to take a look when he is back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addressed issue #1094 . The element name
VariableMultipoleis changed toVariableThinMultipolefor clarity.