Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor regex for default Workflow URLs #277

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Jul 24, 2024

Switch from static base pattern of logic.azure.com to a regex OR pattern to permit either of logic.azure.com or *.azure-api.net as has been observed in the wild.

This also has the side effect of resolving potential CodeQL alerts raised in PR GH-275.

refs GH-262

Switch from static base pattern of `logic.azure.com` to a regex
OR pattern to permit either of `logic.azure.com` or
`*.azure-api.net` as has been observed in the wild.

This also has the side effect of resolving potential CodeQL
alerts raised in PR GH-275.

refs GH-262
@atc0005 atc0005 added bug Something isn't working linting validation labels Jul 24, 2024
@atc0005 atc0005 added this to the v2.11.0-alpha.4 milestone Jul 24, 2024
@atc0005 atc0005 self-assigned this Jul 24, 2024
@atc0005 atc0005 merged commit 7bb323c into development Jul 24, 2024
28 of 29 checks passed
@atc0005 atc0005 deleted the i262-refactor-regex-for-default-workflow-urls branch July 24, 2024 12:34
atc0005 added a commit that referenced this pull request Jul 24, 2024
THIS is the regex pattern intended for GH-277.

Previous commit message:

Switch from static base pattern of `logic.azure.com` to a regex
OR pattern to permit either of `logic.azure.com` or
`*.azure-api.net` as has been observed in the wild.

This also has the side effect of resolving potential
CodeQL alerts raised in PR GH-275.

refs GH-262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linting validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant