Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several changes to the PIDSet implementation, resulting in improved performance and reduced memory allocations.
These changes should improve the overall performance of the PIDSet and reduce memory allocations, making the library more efficient and lightweight.
Benchmarks
Original implementation
Updated implementation
The downside of these changes is that Remove() method now changes the order of elements in the set. It can affect distribution for the round-robin router. But as I can see router usually has a fixed set of routees so It should be fine.
I need this fix because I have a registry actor which can have up to 100k children that spawns and destroys dynamically. And method removeChild causes a significant load.
CPU Profile of my production application