-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port over cluster pubsub, test provider and gossip heartbeat eviction from .net #599 #639 #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kunduin
changed the title
Port over cluster pubsub、test provider、and gossip heartbeat eviction from .net #599 #639
Port over cluster pubsub, test provider and gossip heartbeat eviction from .net #599 #639
Jan 21, 2023
Seems to be missing some deps in the pubsub code:
|
I'll merge and look into the error here :-) |
atomic.Bool seems to be a new feature of go1.19. It may be better to use atomic.int32 or something that go 1.18 support. It is my mistake not to checkout the feat version number 🤣 |
This was referenced Jan 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️❤️❤️ This is a very big pr.
I know it is better not to submit so much code at once, but because cluster pubsub is very complicated so I decided to submit it after all the test cases are passed. Although I have tried to keep the same project structure and naming as .net as much as possible, there are still many interfaces that are not as natural as .net. I will respond to any comment as soon as possible and keep improving this pr. Hopefully this pr will help make the project better.
The cluster pubsub in this pr basically passes all the test cases that appear in the csharp version, the only test case that is missed is
PubSubBatchingProducerTests.Can_handle_publish_timeouts
. This is because the go version ofcluster.Call
does not return nil due to timeouts, while the .net version ofcluster.requestAsync
returns null on timeouts.In order to test pubsub in the cluster, I also implemented Test Provider, gossip heartbeat eviction, gossip graceful left.
Again, sorry for so much code at once. I would be very happy if the maintainer would help to review this part of the code.