Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish should only accept proto.Message #1010

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

qazwsxedckll
Copy link
Contributor

If topic actor is on another node, only proto.Message is accepted. Otherwise endpointSupervisor will crash and the node will be blocked.

@qazwsxedckll qazwsxedckll marked this pull request as draft December 30, 2023 10:11
@qazwsxedckll qazwsxedckll marked this pull request as ready for review December 31, 2023 05:38
@qazwsxedckll
Copy link
Contributor Author

@rogeralsing

I have reproduce the problem here.

Just cd to the folder and run go test -v -tags=integraion ..

The node seems never become healthy again which I cannot figure out why and I am worried about unhealthy node existing without anyone knowing it.

@rogeralsing rogeralsing merged commit 2ecba75 into asynkron:dev Dec 31, 2023
2 checks passed
@qazwsxedckll qazwsxedckll deleted the pubsub-protoMessage branch January 4, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants