-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update meetings.json and newsrooom_videos.json #5048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: update meetings.json and newsrooom_videos.json #5048
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis pull request extends the newsroom videos configuration by appending 120 lines of new video entries to the existing JSON array in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@config/newsroom_videos.json`:
- Around line 87-120: Fix the title typos and spacing: remove the stray space
before commas in the title values for videoId "m-aLlapR2Mg", "ncOFU__8hLM",
"7vvdmDVZPX0", "SaIPQaROWsc", and "xD5smwg6az8", and correct the misspelling
"Auguest" to "August" in the title for videoId "ncOFU__8hLM"; update the
corresponding "title" string values so they read e.g. "AsyncAPI Community WG
Meeting, Tuesday August 12th 2025" (and similarly for the other entries) with no
extra spaces before commas.
- Around line 116-120: There are two entries for "AsyncAPI Community WG Meeting
, Tuesday July 29th 2025" in newsroom_videos.json (one with videoId 7vvdmDVZPX0
and another with videoId xD5smwg6az8); confirm which recording is correct and
remove the duplicate entry (the object containing "videoId": "xD5smwg6az8",
"image_url": "https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg", "title":
"AsyncAPI Community WG Meeting , Tuesday July 29th 2025") if it’s unintended, or
merge/update the record to a single entry ensuring the correct videoId and
image_url are used.
- Around line 140-144: There are two entries with identical "title" "AsyncAPI
Design WG Meeting, Tuesday June 17th 2025" and the same "description"
referencing issue `#1935` but different "videoId" values ("0srKJiLCIUc" vs
"uVAurockaPc"); confirm whether these are distinct recordings and if not remove
the duplicate entry that matches that title/description (e.g., remove the object
with "videoId": "0srKJiLCIUc" shown in the diff), or if both are valid, update
one of them to include distinguishing metadata (e.g., date/time or “Part 1/Part
2”) so they are not identical, and ensure the surrounding JSON commas/structure
remain valid after the change.
| "image_url": "https://i.ytimg.com/vi/m-aLlapR2Mg/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday September 9th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2060.", | ||
| "videoId": "m-aLlapR2Mg" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/XjckzYopxoA/hqdefault.jpg", | ||
| "title": "AsyncAPI Mentorship Program Wrap-Up - 2024", | ||
| "description": "The livestream will serve as the official wrap-up of the AsyncAPI 2024 Mentorship Program. It's an opportunity for mentors and ...", | ||
| "videoId": "XjckzYopxoA" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2014.", | ||
| "videoId": "ncOFU__8hLM" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/7vvdmDVZPX0/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "7vvdmDVZPX0" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/SaIPQaROWsc/hqdefault.jpg", | ||
| "title": "First Meeting of New Governance Board , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1989.", | ||
| "videoId": "SaIPQaROWsc" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "xD5smwg6az8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix title typos and spacing inconsistencies.
Line 88, Line 100, Line 106, Line 112, and Line 118 contain an extra space before commas and a misspelling (“Auguest”). These are user-facing and should be corrected.
🧹 Proposed cleanup
- "title": "AsyncAPI Community WG Meeting , Tuesday September 9th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday September 9th 2025",
@@
- "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025",
@@
- "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday July 29th 2025",
@@
- "title": "First Meeting of New Governance Board , Tuesday July 29th 2025",
+ "title": "First Meeting of New Governance Board, Tuesday July 29th 2025",
@@
- "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday July 29th 2025",🤖 Prompt for AI Agents
In `@config/newsroom_videos.json` around lines 87 - 120, Fix the title typos and
spacing: remove the stray space before commas in the title values for videoId
"m-aLlapR2Mg", "ncOFU__8hLM", "7vvdmDVZPX0", "SaIPQaROWsc", and "xD5smwg6az8",
and correct the misspelling "Auguest" to "August" in the title for videoId
"ncOFU__8hLM"; update the corresponding "title" string values so they read e.g.
"AsyncAPI Community WG Meeting, Tuesday August 12th 2025" (and similarly for the
other entries) with no extra spaces before commas.
| { | ||
| "image_url": "https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "xD5smwg6az8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n config/newsroom_videos.json | sed -n '100,125p'Repository: asyncapi/website
Length of output: 1399
Confirm whether duplicate July 29th Community WG meeting entries are intentional.
Lines 104-109 and 116-121 both reference "AsyncAPI Community WG Meeting , Tuesday July 29th 2025" with the same issue (1988), but have different videoIds (7vvdmDVZPX0 vs xD5smwg6az8) and image URLs. If only one recording should be listed, remove the duplicate entry at lines 116-121.
🤖 Prompt for AI Agents
In `@config/newsroom_videos.json` around lines 116 - 120, There are two entries
for "AsyncAPI Community WG Meeting , Tuesday July 29th 2025" in
newsroom_videos.json (one with videoId 7vvdmDVZPX0 and another with videoId
xD5smwg6az8); confirm which recording is correct and remove the duplicate entry
(the object containing "videoId": "xD5smwg6az8", "image_url":
"https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg", "title": "AsyncAPI Community
WG Meeting , Tuesday July 29th 2025") if it’s unintended, or merge/update the
record to a single entry ensuring the correct videoId and image_url are used.
| { | ||
| "image_url": "https://i.ytimg.com/vi/0srKJiLCIUc/hqdefault.jpg", | ||
| "title": "AsyncAPI Design WG Meeting, Tuesday June 17th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1935.", | ||
| "videoId": "0srKJiLCIUc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n config/newsroom_videos.json | sed -n '130,150p'Repository: asyncapi/website
Length of output: 1121
Remove duplicate "AsyncAPI Design WG Meeting, Tuesday June 17th 2025" entry.
Lines 141-144 duplicate lines 135-138 with identical title and description referencing the same GitHub issue #1935. While the video IDs differ (0srKJiLCIUc vs uVAurockaPc), having two entries with identical metadata for what appears to be the same meeting/topic is likely unintended. Confirm whether both represent distinct recordings that should both be listed, or remove the duplicate.
🤖 Prompt for AI Agents
In `@config/newsroom_videos.json` around lines 140 - 144, There are two entries
with identical "title" "AsyncAPI Design WG Meeting, Tuesday June 17th 2025" and
the same "description" referencing issue `#1935` but different "videoId" values
("0srKJiLCIUc" vs "uVAurockaPc"); confirm whether these are distinct recordings
and if not remove the duplicate entry that matches that title/description (e.g.,
remove the object with "videoId": "0srKJiLCIUc" shown in the diff), or if both
are valid, update one of them to include distinguishing metadata (e.g.,
date/time or “Part 1/Part 2”) so they are not identical, and ensure the
surrounding JSON commas/structure remain valid after the change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5048 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5048--asyncapi-website.netlify.app/ |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.