-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: remove AsyncAPI CLI duplication across tools categories #4969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: remove AsyncAPI CLI duplication across tools categories #4969
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughConfiguration file updated to remove two AsyncAPI CLI tool entries and their associated metadata from the tools registry. The changes include cleanup of references in the Others section and a minor formatting adjustment to the Others key declaration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4969--asyncapi-website.netlify.app/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4969 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @princerajpoot20 |
Description
This PR fixes an obvious data issue in the tools configuration where AsyncAPI CLI was listed multiple times across the Tools page.
Specifically, it:
This change is a pure data correction and does not modify any UI or filtering logic.
Current Behavior
Screen Recording of Duplicates and issue
Untitled.video.-.Made.with.Clipchamp.3.mp4
What This PR Fixes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.