Skip to content

Conversation

@Yashmeet-3000
Copy link

@Yashmeet-3000 Yashmeet-3000 commented Jan 16, 2026

Description

  • This PR fixes the "Contributing" navigation link which was incorrectly redirecting users to an external GitHub organization page instead of our internal documentation.

Changes

  • Navigation Fix: Updated the href in CommunityItem.tsx to point to the internal path /docs/community/010-contribution-guidelines.
  • CI Stability: Reverted accidental dependency upgrades in package.json for @typescript-eslint plugins to ensure compatibility with the current project environment and resolve ERESOLVE errors in the build pipeline.

Verification

  • Verified the link behavior on a local development server.
  • Confirmed that the "Contributing" menu item now correctly renders the internal guide.

Closes #4909

Summary by CodeRabbit

  • New Features

    • Added "AsyncAPI Spec Triage" meeting event to the calendar.
  • Updates

    • Contributing link now routes to internal documentation instead of an external resource.
    • Navigation button styling enhanced with improved padding and refined icon sizing.

✏️ Tip: You can customize this high-level summary in your review settings.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 76c2b3d
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/696a945df79061000897f0a2
😎 Deploy Preview https://deploy-preview-4965--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

📝 Walkthrough

Walkthrough

Four files modified across navigation, configuration, styling, and dependencies. The Contributing link in the community navigation redirects to an internal documentation path instead of an external URL. Button styling updated with adjusted padding and icon size. A new meeting entry added to the meetings configuration, and a new i18n dependency introduced.

Changes

Cohort / File(s) Summary
Navigation & Configuration
components/navigation/communityItems.tsx, config/meetings.json
Contributing link href changed from external GitHub URL to internal path (/docs/community/010-contribution-guidelines); target attribute removed. New AsyncAPI Spec Triage meeting entry added with date 2026-01-22 and calendar/issue links.
UI Styling
components/newsroom/NewsroomBlogPosts.tsx
Next button horizontal padding increased px-4 → px-6, vertical padding py-1 → py-3; ArrowRight icon size reduced w-8 → w-4.
Dependencies
package.json
Added react-i18next ^14.1.0 as new runtime dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The Contributing link now hops,
To the right page—no more stops!
Buttons padded, meetings set,
i18next joins the crew yet,
Simple changes, nicely met!

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes out-of-scope changes: styling updates to NewsroomBlogPosts, a new meeting entry in config/meetings.json, and a new react-i18next dependency unrelated to the contributing link fix. Remove unrelated changes (NewsroomBlogPosts styling, meetings.json entry, react-i18next dependency) to keep the PR focused on fixing the contributing link as described in issue #4909.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: redirecting the community contribution link to internal docs, which is the primary objective of the PR.
Linked Issues check ✅ Passed The PR addresses issue #4909 by changing the Contributing link href to /docs/community/010-contribution-guidelines and removing the external _blank target, meeting the stated objective.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 37
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-4965--asyncapi-website.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Be Triaged

Development

Successfully merging this pull request may close these issues.

[BUG] “Contributing” link in Community navbar dropdown redirects to incorrect page

2 participants