-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(cli): update latest cli documentation #4856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asyncapi-bot
merged 1 commit into
master
from
update-cli-docs-74109c6e400dde26b73dea5100a77cf344307905
Jan 2, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| --- | ||
| title: 'Contributing via Pull Requests' | ||
| weight: 50 | ||
| --- | ||
|
|
||
| # Contributing via Pull Requests | ||
|
|
||
| ## Getting Started | ||
|
|
||
| 1. **Open an issue first** (unless it's a trivial fix) | ||
| 2. **Set up environment** — Follow [DEVELOPMENT.md](../DEVELOPMENT.md) | ||
| 3. **Create a branch** — Use prefixes: `feat/`, `fix/`, `docs/`, `refactor/`, `test/`, `chore/` | ||
|
|
||
| --- | ||
|
|
||
| ## PR Title Format | ||
|
|
||
| Follow [Conventional Commits](https://www.conventionalcommits.org/): | ||
|
|
||
| | Type | Description | Release | | ||
| |------|-------------|---------| | ||
| | `feat:` | New feature | MINOR | | ||
| | `fix:` | Bug fix | PATCH | | ||
| | `docs:` | Documentation | None | | ||
| | `chore:` | Maintenance | None | | ||
| | `test:` | Tests only | None | | ||
| | `refactor:` | Code refactoring | None | | ||
|
|
||
| **Breaking changes:** Add `!` → `feat!:`, `fix!:` | ||
|
|
||
| **Examples:** | ||
| - ✅ `feat: add AsyncAPI 3.0 validation support` | ||
| - ✅ `fix: resolve context loading with special characters` | ||
| - ❌ `Added new feature` | ||
| - ❌ `fix bug` | ||
|
|
||
| --- | ||
|
|
||
| ## PR Checklist | ||
|
|
||
| **Before submitting:** | ||
| - [ ] Branch synced with `main` | ||
| - [ ] `npm run build` passes | ||
| - [ ] `npm run cli:test` passes | ||
| - [ ] `npm run lint` passes (max 5 warnings) | ||
| - [ ] Documentation updated (if needed) | ||
|
|
||
| **Code quality:** | ||
| - [ ] Follows existing code patterns | ||
| - [ ] TypeScript types used (avoid `any`) | ||
| - [ ] Error handling implemented | ||
| - [ ] Tests added for new functionality | ||
| - [ ] No `console.log` or commented code | ||
|
|
||
| --- | ||
|
|
||
| ## Code Standards | ||
|
|
||
| | Area | Guideline | | ||
| |------|-----------| | ||
| | **TypeScript** | Explicit types, interfaces for objects, prefer `const` | | ||
| | **Organization** | Follow existing structure, use path aliases (`@/`, `@cli/`, `@domains/`) | | ||
| | **Errors** | Use custom errors from `src/errors/`, return `ServiceResult<T>` from services | | ||
| | **Commands** | Extend base `Command`, use domain services for business logic | | ||
|
|
||
| --- | ||
|
|
||
| ## Testing | ||
|
|
||
| **Add tests for:** | ||
| - New commands or API endpoints | ||
| - Bug fixes (regression tests) | ||
| - New domain services | ||
| - Complex business logic | ||
|
|
||
| ```bash | ||
| npm run cli:test # All tests | ||
| npm run unit:test # Unit tests only | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ## Best Practices | ||
|
|
||
| | ❌ Avoid | ✅ Do | | ||
| |----------|-------| | ||
| | Large PRs (>500 lines) | Small, focused PRs | | ||
| | Multiple concerns in one PR | One issue per PR | | ||
| | Skipping tests | Comprehensive tests | | ||
| | Hardcoded values | Externalize configuration | | ||
| | Force push to main | Rebase instead of merge | | ||
|
|
||
| --- | ||
|
|
||
| ## Review Process | ||
|
|
||
| 1. CI runs automated checks | ||
| 2. Maintainers review code | ||
| 3. Address feedback promptly | ||
| 4. PR merged when approved | ||
|
|
||
| --- | ||
|
|
||
| ## Quick Reference | ||
|
|
||
| ```bash | ||
| # Setup | ||
| npm install && npx lefthook install | ||
|
|
||
| # Before PR | ||
| npm run build && npm run lint && npm run cli:test | ||
| ``` | ||
|
|
||
| **Quality over speed** — Write good code, tests, and documentation. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: asyncapi/website
Length of output: 249
🏁 Script executed:
Repository: asyncapi/website
Length of output: 1423
Remove or configure the documented path aliases (@cli/, @domains/).
The tsconfig.json only defines a single path alias:
@/*->./*. The documentation on line 62 lists@/,@cli/, and@domains/, but@cli/and@domains/do not exist in the TypeScript configuration and have no usage in the codebase. Either remove the non-existent aliases from the documentation or add them to tsconfig.json if they're intended for future use.🤖 Prompt for AI Agents