Skip to content

Conversation

@asyncapi-bot
Copy link
Contributor

@asyncapi-bot asyncapi-bot commented Dec 30, 2025

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • New Features
    • Expanded newsroom video library with additional video entries, each including images, titles, descriptions, and video identifiers.

✏️ Tip: You can customize this high-level summary in your review settings.

@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit f088c6b
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/69531fc55ffb41000863f849
😎 Deploy Preview https://deploy-preview-4806--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

This pull request expands the newsroom video configuration by adding multiple new video entries to config/newsroom_videos.json. Each entry includes metadata such as image URL, title, description, and video ID. No functional logic or control flow is modified.

Changes

Cohort / File(s) Summary
Video Configuration Data
config/newsroom_videos.json
Added multiple new video entry objects to the JSON array, each containing image_url, title, description, and videoId fields. Existing entries remain unchanged. Data-only expansion with no structural modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

autoapproved, autoupdate

Suggested reviewers

  • derberg
  • princerajpoot20
  • akshatnema
  • sambhavgupta0705
  • anshgoyalevil
  • Mayaleeeee
  • devilkiller-ag
  • vishvamsinh28
  • asyncapi-bot-eve

Poem

🐰 A bushy-tailed celebration

New videos hop into view,
Metadata dancing in JSON brew,
No logic changed, just data so true—
The newsroom grows, shiny and new! 🎬✨

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions updating meetings.json and newsrooom_videos.json, but the raw summary only documents changes to newsroom_videos.json with no meetings.json changes described. Update the PR title to accurately reflect only the files actually changed (newsroom_videos.json), or clarify if meetings.json was also modified and document those changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (438b259) to head (f088c6b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4806   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          798       798           
  Branches       146       146           
=========================================
  Hits           798       798           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asyncapi-bot asyncapi-bot merged commit 1089dbc into master Dec 30, 2025
37 of 38 checks passed
@asyncapi-bot asyncapi-bot deleted the update-meetings/438b25932a0756111f991bae50f568b469e6a6e2 branch December 30, 2025 00:45
@asyncapi-bot
Copy link
Contributor Author

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 38
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-4806--asyncapi-website.netlify.app/

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
config/newsroom_videos.json (1)

50-55: Consider using a plain apostrophe instead of HTML entity.

Line 52 uses the HTML entity ' for the apostrophe in "AsyncAPI's". While this is valid JSON, using a plain apostrophe character (') would be more readable and is typical for JSON data.

🔎 Proposed refinement
-    "title": "One Tool, One Flow: AsyncAPI's New Take on Code/Docs/Config Generation",
+    "title": "One Tool, One Flow: AsyncAPI's New Take on Code/Docs/Config Generation",
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 438b259 and f088c6b.

📒 Files selected for processing (1)
  • config/newsroom_videos.json
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Automerge PR autoapproved by a bot
  • GitHub Check: Redirect rules - asyncapi-website
  • GitHub Check: Header rules - asyncapi-website
  • GitHub Check: Pages changed - asyncapi-website
  • GitHub Check: cypress-run
  • GitHub Check: Test NodeJS PR - windows-latest
  • GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/newsroom_videos.json (1)

122-151: Verify duplicate entries with identical titles.

Multiple entries share the same title and date but have different video IDs:

  1. June 17th Design WG Meeting appears twice:

    • Lines 122-127: videoId uVAurockaPc
    • Lines 128-133: videoId 0srKJiLCIUc
  2. June 3rd Community WG Meeting appears twice:

    • Lines 140-145: videoId JLNMJ5A8sns
    • Lines 146-151: videoId mhYxES2b13U

Please verify whether these represent legitimately separate sessions or if one of each pair should be removed.

Comment on lines +74 to +109
{
"image_url": "https://i.ytimg.com/vi/m-aLlapR2Mg/hqdefault.jpg",
"title": "AsyncAPI Community WG Meeting , Tuesday September 9th 2025",
"description": "https://github.com/asyncapi/community/issues/2060.",
"videoId": "m-aLlapR2Mg"
},
{
"image_url": "https://i.ytimg.com/vi/XjckzYopxoA/hqdefault.jpg",
"title": "AsyncAPI Mentorship Program Wrap-Up - 2024",
"description": "The livestream will serve as the official wrap-up of the AsyncAPI 2024 Mentorship Program. It's an opportunity for mentors and ...",
"videoId": "XjckzYopxoA"
},
{
"image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg",
"title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
"description": "https://github.com/asyncapi/community/issues/2014.",
"videoId": "ncOFU__8hLM"
},
{
"image_url": "https://i.ytimg.com/vi/7vvdmDVZPX0/hqdefault.jpg",
"title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025",
"description": "https://github.com/asyncapi/community/issues/1988.",
"videoId": "7vvdmDVZPX0"
},
{
"image_url": "https://i.ytimg.com/vi/SaIPQaROWsc/hqdefault.jpg",
"title": "First Meeting of New Governance Board , Tuesday July 29th 2025",
"description": "https://github.com/asyncapi/community/issues/1989.",
"videoId": "SaIPQaROWsc"
},
{
"image_url": "https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg",
"title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025",
"description": "https://github.com/asyncapi/community/issues/1988.",
"videoId": "xD5smwg6az8"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

cat -n config/newsroom_videos.json | sed -n '74,109p'

Repository: asyncapi/website

Length of output: 1900


Fix spacing inconsistencies and typo in meeting titles; verify duplicate entries.

Lines 76, 88, 94, 100, 106 all contain an extra space before the comma in their titles (e.g., "Meeting ," should be "Meeting,"). Additionally, line 88 has a typo: "Auguest" should be "August".

Two entries share the same title "AsyncAPI Community WG Meeting , Tuesday July 29th 2025" but have different video IDs:

  • Line 94-97: videoId 7vvdmDVZPX0
  • Line 106-109: videoId xD5smwg6az8

Verify whether these represent separate meetings or a data quality issue.

🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 74 to 109, fix spacing and a typo in
titles and verify duplicate entries: remove the extra space before the comma in
titles on lines 76, 88, 94, 100 and 106 (change "Meeting ," to "Meeting," and
similar), correct the typo "Auguest" to "August" on line 88, and investigate the
two "AsyncAPI Community WG Meeting, Tuesday July 29th 2025" entries (lines 94–97
videoId 7vvdmDVZPX0 and lines 106–109 videoId xD5smwg6az8) — if they are the
same meeting deduplicate or merge metadata; if they are distinct, update
title/date/description to clearly differentiate them.

Comment on lines +86 to +91
{
"image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg",
"title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
"description": "https://github.com/asyncapi/community/issues/2014.",
"videoId": "ncOFU__8hLM"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the typo in the month name.

Line 88 contains a spelling error: "Auguest" should be "August".

🔎 Proposed fix
-    "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
+    "title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025",

Note: This also removes the extra space before the comma for consistency.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
"image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg",
"title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
"description": "https://github.com/asyncapi/community/issues/2014.",
"videoId": "ncOFU__8hLM"
},
{
"image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg",
"title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025",
"description": "https://github.com/asyncapi/community/issues/2014.",
"videoId": "ncOFU__8hLM"
},
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 86 to 91, fix the typo in the title
at line 88 by changing "Auguest" to "August" and remove the extra space before
the comma so the title reads "AsyncAPI Community WG Meeting, Tuesday August 12th
2025"; update the JSON string value accordingly and ensure the file remains
valid JSON (quotes and commas unchanged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants