-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update meetings.json and newsrooom_videos.json #4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4806
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis pull request expands the newsroom video configuration by adding multiple new video entries to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4806 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 798 798
Branches 146 146
=========================================
Hits 798 798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4806--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
config/newsroom_videos.json (1)
50-55: Consider using a plain apostrophe instead of HTML entity.Line 52 uses the HTML entity
'for the apostrophe in "AsyncAPI's". While this is valid JSON, using a plain apostrophe character (') would be more readable and is typical for JSON data.🔎 Proposed refinement
- "title": "One Tool, One Flow: AsyncAPI's New Take on Code/Docs/Config Generation", + "title": "One Tool, One Flow: AsyncAPI's New Take on Code/Docs/Config Generation",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/newsroom_videos.json
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: cypress-run
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/newsroom_videos.json (1)
122-151: Verify duplicate entries with identical titles.Multiple entries share the same title and date but have different video IDs:
June 17th Design WG Meeting appears twice:
- Lines 122-127: videoId
uVAurockaPc- Lines 128-133: videoId
0srKJiLCIUcJune 3rd Community WG Meeting appears twice:
- Lines 140-145: videoId
JLNMJ5A8sns- Lines 146-151: videoId
mhYxES2b13UPlease verify whether these represent legitimately separate sessions or if one of each pair should be removed.
| { | ||
| "image_url": "https://i.ytimg.com/vi/m-aLlapR2Mg/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday September 9th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2060.", | ||
| "videoId": "m-aLlapR2Mg" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/XjckzYopxoA/hqdefault.jpg", | ||
| "title": "AsyncAPI Mentorship Program Wrap-Up - 2024", | ||
| "description": "The livestream will serve as the official wrap-up of the AsyncAPI 2024 Mentorship Program. It's an opportunity for mentors and ...", | ||
| "videoId": "XjckzYopxoA" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2014.", | ||
| "videoId": "ncOFU__8hLM" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/7vvdmDVZPX0/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "7vvdmDVZPX0" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/SaIPQaROWsc/hqdefault.jpg", | ||
| "title": "First Meeting of New Governance Board , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1989.", | ||
| "videoId": "SaIPQaROWsc" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "xD5smwg6az8" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n config/newsroom_videos.json | sed -n '74,109p'Repository: asyncapi/website
Length of output: 1900
Fix spacing inconsistencies and typo in meeting titles; verify duplicate entries.
Lines 76, 88, 94, 100, 106 all contain an extra space before the comma in their titles (e.g., "Meeting ," should be "Meeting,"). Additionally, line 88 has a typo: "Auguest" should be "August".
Two entries share the same title "AsyncAPI Community WG Meeting , Tuesday July 29th 2025" but have different video IDs:
- Line 94-97: videoId
7vvdmDVZPX0 - Line 106-109: videoId
xD5smwg6az8
Verify whether these represent separate meetings or a data quality issue.
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 74 to 109, fix spacing and a typo in
titles and verify duplicate entries: remove the extra space before the comma in
titles on lines 76, 88, 94, 100 and 106 (change "Meeting ," to "Meeting," and
similar), correct the typo "Auguest" to "August" on line 88, and investigate the
two "AsyncAPI Community WG Meeting, Tuesday July 29th 2025" entries (lines 94–97
videoId 7vvdmDVZPX0 and lines 106–109 videoId xD5smwg6az8) — if they are the
same meeting deduplicate or merge metadata; if they are distinct, update
title/date/description to clearly differentiate them.
| { | ||
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2014.", | ||
| "videoId": "ncOFU__8hLM" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the typo in the month name.
Line 88 contains a spelling error: "Auguest" should be "August".
🔎 Proposed fix
- "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025",Note: This also removes the extra space before the comma for consistency.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2014.", | |
| "videoId": "ncOFU__8hLM" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2014.", | |
| "videoId": "ncOFU__8hLM" | |
| }, |
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 86 to 91, fix the typo in the title
at line 88 by changing "Auguest" to "August" and remove the extra space before
the comma so the title reads "AsyncAPI Community WG Meeting, Tuesday August 12th
2025"; update the JSON string value accordingly and ensure the file remains
valid JSON (quotes and commas unchanged).
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.