-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: replace bitly urls with netlify redirect #4647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
eab3b83
update bit.ly urls to use /s/asyncapiv2
vishvamsinh28 07d96b9
Merge branch 'master' into addShortUrls
vishvamsinh28 1e1edf6
Merge branch 'master' into addShortUrls
princerajpoot20 a6bb44e
Merge branch 'master' into addShortUrls
vishvamsinh28 260bc9a
Merge branch 'master' into addShortUrls
vishvamsinh28 f64e633
Merge branch 'master' into addShortUrls
vishvamsinh28 aaf9e31
Merge branch 'master' into addShortUrls
vishvamsinh28 81cf1c4
Merge branch 'master' into addShortUrls
thulieblack 52ec387
Merge branch 'master' into addShortUrls
thulieblack ad0220d
add empty line
vishvamsinh28 c4d6bb0
remove empty line
vishvamsinh28 b1026b6
apply coderabbit suggestion
vishvamsinh28 c20a884
Merge branch 'master' into addShortUrls
princerajpoot20 d4d7023
Merge branch 'master' into addShortUrls
vishvamsinh28 bf9e5ba
Merge branch 'master' into addShortUrls
anshgoyalevil a86a4fc
Merge branch 'master' into addShortUrls
vishvamsinh28 78faa40
Merge branch 'master' into addShortUrls
thulieblack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,30 @@ | ||
| { | ||
| "@asyncapi/html-template@3.0.0": { | ||
| "flag": "-o example --use-new-generator", | ||
| "specPath" : "https://bit.ly/asyncapi" | ||
| "specPath" : "https://asyncapi.com/s/asyncapiv2" | ||
| }, | ||
| "@asyncapi/markdown-template": { | ||
| "flag": "-o example", | ||
| "specPath" : "https://bit.ly/asyncapi" | ||
| "specPath" : "https://asyncapi.com/s/asyncapiv2" | ||
| }, | ||
| "@asyncapi/nodejs-template": { | ||
| "flag": "-p server=production -o example", | ||
| "specPath" : "https://bit.ly/asyncapi" | ||
| "specPath" : "https://asyncapi.com/s/asyncapiv2" | ||
| }, | ||
| "@asyncapi/nodejs-ws-template": { | ||
| "flag": "-p server=localhost -o example", | ||
| "specPath" : "https://raw.githubusercontent.com/asyncapi/generator/v1.4.0/test/docs/ws.yml" | ||
| }, | ||
| "@asyncapi/java-spring-cloud-stream-template": { | ||
| "flag": "-o example", | ||
| "specPath" : "https://bit.ly/asyncapi" | ||
| "specPath" : "https://asyncapi.com/s/asyncapiv2" | ||
| }, | ||
| "@asyncapi/java-spring-template": { | ||
| "flag": "-o example", | ||
| "specPath" : "https://bit.ly/asyncapi" | ||
| "specPath" : "https://asyncapi.com/s/asyncapiv2" | ||
| }, | ||
| "@asyncapi/python-paho-template": { | ||
| "flag": "-o example", | ||
| "specPath" : "https://bit.ly/asyncapi" | ||
| "specPath" : "https://asyncapi.com/s/asyncapiv2" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirect target URL is accessible, but confirm the version strategy is intentional.
The target URL returns valid AsyncAPI 2.0.0 content. However, version 2.0.0 was released in 2019, and AsyncAPI has since released v2.5.0 and v3.0.0 with significant improvements. If the original bit.ly URL was pointing to v2.0.0 for backward compatibility, the redirect preserves that. Otherwise, consider whether using the latest v2.x or v3.0.0 streetlights example would better serve users.
🤖 Prompt for AI Agents