Skip to content

fix: updated the Github Button to IconGithub Button when screen size becomes small #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BensOmnitrix wants to merge 6 commits into from
Closed

fix: updated the Github Button to IconGithub Button when screen size becomes small #4580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d8f5c0
Fix: Updated the Github Button to IconGithub Button when screen size …
BensOmnitrix Nov 12, 2025
59b57c9
Patch to run the PR Workflow
BensOmnitrix Nov 12, 2025
7fa0830
fix: Improved the spacing as suggested by the bot
BensOmnitrix Nov 12, 2025
af50e19
Revert "fix: Improved the spacing as suggested by the bot"
BensOmnitrix Nov 12, 2025
511bf24
Merge branch 'master' into fix/github-button-responsiveness
BensOmnitrix Nov 13, 2025
cd3450c
Merge branch 'master' into fix/github-button-responsiveness
BensOmnitrix Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions components/buttons/GithubButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import Link from 'next/link';
import React from 'react';

import { ButtonIconPosition, ButtonSize } from '@/types/components/buttons/ButtonPropsType';
Expand Down Expand Up @@ -30,16 +31,21 @@ export default function GithubButton({
const { t } = useTranslation('common');

return (
<Button
text={t(text)}
icon={<IconGithub className='-mt-1 inline-block size-6' />}
href={href}
iconPosition={iconPosition}
target={target}
className={className}
data-testid='Github-button'
bgClassName='bg-gray-800 hover:bg-gray-700'
buttonSize={inNav ? ButtonSize.SMALL : ButtonSize.DEFAULT}
/>
<div>
<Button
text={t(text)}
icon={<IconGithub className='-mt-1 inline-block size-6' />}
href={href}
iconPosition={iconPosition}
target={target}
className={`${className}ml-1 hidden xl:inline-block`}
data-testid='Github-button'
bgClassName='bg-gray-800 hover:bg-gray-700'
buttonSize={inNav ? ButtonSize.SMALL : ButtonSize.DEFAULT}
/>
<Link href={href} target={target} aria-label='Visit AsyncAPI Github Repository'>
<IconGithub className='-mt-1 ml-2 inline-block size-8 xl:hidden' />
</Link>
</div>
);
}
2 changes: 1 addition & 1 deletion scripts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ async function start() {
return parseFloat(b) - parseFloat(a);
});

if (yearsList.length === 0) {
if (!yearsList || yearsList.length === 0) {
throw new Error('No finance data found in the finance directory.');
}

Expand Down
Loading