Skip to content

fix: star-on-github-button-responsiveness #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BensOmnitrix wants to merge 1 commit into from
Closed

fix: star-on-github-button-responsiveness #4576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions components/buttons/GithubButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import type { IButtonDefaultProps } from '../../types/components/buttons/types';
import { useTranslation } from '../../utils/i18n';
import IconGithub from '../icons/Github';
import Button from './Button';
import Link from 'next/link';
import { useWindowSize } from '@/utils/windowSize';

interface IGithubButtonProps extends IButtonDefaultProps {
inNav?: boolean;
Expand All @@ -28,18 +30,27 @@ export default function GithubButton({
inNav
}: IGithubButtonProps) {
const { t } = useTranslation('common');
const { width } = useWindowSize();

return (
<Button
text={t(text)}
icon={<IconGithub className='-mt-1 inline-block size-6' />}
href={href}
iconPosition={iconPosition}
target={target}
className={className}
data-testid='Github-button'
bgClassName='bg-gray-800 hover:bg-gray-700'
buttonSize={inNav ? ButtonSize.SMALL : ButtonSize.DEFAULT}
/>
<div className="flex items-center">
{width > 1144 ? (
<Button
text={t(text)}
icon={<IconGithub className="-mt-1 inline-block size-6" />}
href={href}
iconPosition={iconPosition}
target={target}
className={className}
data-testid="Github-button"
bgClassName="bg-gray-800 hover:bg-gray-700"
buttonSize={inNav ? ButtonSize.SMALL : ButtonSize.DEFAULT}
/>
) : (
<Link href="https://github.com/asyncapi" target="_blank">
<IconGithub className="-mt-1 ml-5 inline-block size-8 cursor-pointer" />
</Link>
)}
</div>
);
}
Loading
Loading