-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add social share buttons to blog posts #4557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -23,7 +23,7 @@ | |||||
| "title": "AsyncAPI Server API", | ||||||
| "description": "Server API providing official AsyncAPI tools", | ||||||
| "links": { | ||||||
| "websiteUrl": "https://api.asyncapi.com/v1", | ||||||
| "websiteUrl": "https://api.asyncapi.com/v1", | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove trailing whitespace. Trailing whitespace after the URL value serves no purpose and may trigger linting failures or cause inconsistencies in version control. Apply this diff to remove the trailing whitespace: - "websiteUrl": "https://api.asyncapi.com/v1",
+ "websiteUrl": "https://api.asyncapi.com/v1",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| "docsUrl": "https://api.asyncapi.com/v1/docs", | ||||||
| "repoUrl": "https://github.com/asyncapi/server-api" | ||||||
| }, | ||||||
|
|
||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Use environment variable for base URL and simplify variable assignment.
The hardcoded base URL
https://www.asyncapi.comwill break in development/staging environments. Additionally, thepostTitlevariable is redundant since it simply copiespost.title.Apply this diff:
Then use
post.titledirectly in the share buttons instead ofpostTitle.🤖 Prompt for AI Agents