-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(community): update latest tsc members list #4494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(community): update latest tsc members list #4494
Conversation
❌ Deploy Preview for asyncapi-website failed.
|
WalkthroughAdds Zbigniew Malcherczyk as a new ambassador to the members configuration with full profile details including GitHub handle, LinkedIn, company affiliation, and four recorded contributions. The same entry appears twice in the file, indicating a duplicate. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The JSON structure is straightforward, but the duplicate entry requires verification and correction before merging. Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4494 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/AMBASSADORS_MEMBERS.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
| { | ||
| "name": "Zbigniew Malcherczyk", | ||
| "github": "ferror", | ||
| "githubID": 17534504, | ||
| "linkedin": "http://linkedin.com/in/zbigniew-malcherczyk/", | ||
| "twitter": "", | ||
| "country": "\ud83c\uddf5\ud83c\uddf1", | ||
| "company": "TransferGo", | ||
| "title": "Staff Backend Engineer", | ||
| "img": "https://avatars.githubusercontent.com/u/17534504?v=4", | ||
| "contributions": [ | ||
| { | ||
| "type": "article", | ||
| "title": "How TransferGo adopted AsyncAPI", | ||
| "date": { | ||
| "year": 2025, | ||
| "month": "October" | ||
| }, | ||
| "link": "https://www.asyncapi.com/blog/transfergo-asyncapi-story" | ||
| }, | ||
| { | ||
| "type": "casestudy", | ||
| "title": "How TransferGo adopted AsyncAPI", | ||
| "date": { | ||
| "year": 2025, | ||
| "month": "September" | ||
| }, | ||
| "link": "https://www.asyncapi.com/casestudies/transfergo" | ||
| }, | ||
| { | ||
| "type": "talk", | ||
| "title": "Studium przypadku asynchronicznej konsumpcji zdarze\u0144 w domenie finansowej", | ||
| "date": { | ||
| "year": 2023, | ||
| "month": "September" | ||
| }, | ||
| "link": "https://www.youtube.com/watch?v=CtiqwMbOBes" | ||
| }, | ||
| { | ||
| "type": "talk", | ||
| "title": "How TransferGo uses AsyncAPI to improve Developer Experience", | ||
| "date": { | ||
| "year": 2023, | ||
| "month": "December" | ||
| }, | ||
| "link": "https://github.com/Ferror/keynotes/blob/master/asyncapi-2023-developer-experience.pdf" | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Missing required fields for TSC member entry.
Given the PR objective to "update latest tsc members list," this entry is missing:
"bio"field (required in all other entries)- Clarity on
"isTscMember"flag (other TSC members like Daniel Kocot, Hugo Guerrero, Hari Krishnan, and Naresh Jain have"isTscMember": true)
Compare the structure against existing TSC members (e.g., line 65 for Daniel Kocot) to ensure consistency and completeness.
Is Zbigniew Malcherczyk being added as a TSC member? If so, add the missing "isTscMember": true field and a "bio" field to match other entries.
I'll verify the claims in the review comment by examining the JSON file structure.
---
🏁 Script executed:
```shell
#!/bin/bash
# Check field presence across entries and specifically examine existing TSC members
jq '.[] | {name: .name, has_bio: (has("bio")), has_isTscMember: (has("isTscMember")), isTscMember: .isTscMember}' config/AMBASSADORS_MEMBERS.json | head -100
Length of output: 1317
🏁 Script executed:
#!/bin/bash
# Check entries around the mentioned line references to understand structure
jq '.[] | select(.name == "Daniel Kocot" or .name == "Hugo Guerrero" or .name == "Hari Krishnan" or .name == "Naresh Jain" or .name == "Zbigniew Malcherczyk") | {name: .name, has_bio: (has("bio")), has_isTscMember: (has("isTscMember")), isTscMember: .isTscMember}' config/AMBASSADORS_MEMBERS.jsonLength of output: 500
🏁 Script executed:
#!/bin/bash
# Count how many entries have "bio" field vs those that don't
echo "=== Entries with bio field ==="
jq '[.[] | select(has("bio"))] | length' config/AMBASSADORS_MEMBERS.json
echo "=== Total entries ==="
jq 'length' config/AMBASSADORS_MEMBERS.json
echo "=== Entries with isTscMember flag ==="
jq '[.[] | select(has("isTscMember"))] | length' config/AMBASSADORS_MEMBERS.jsonLength of output: 98
🏁 Script executed:
#!/bin/bash
# Check the Zbigniew entry specifically
jq '.[] | select(.name == "Zbigniew Malcherczyk")' config/AMBASSADORS_MEMBERS.jsonLength of output: 1354
Add missing bio field and clarify TSC member status.
The entry is missing two standard fields present in all other TSC members:
"bio"field (present in 12 of 13 entries; Zbigniew is the only exception)"isTscMember": trueflag (present in all four existing TSC members: Daniel Kocot, Hugo Guerrero, Hari Krishnan, Naresh Jain)
If Zbigniew is being added as a TSC member (as the PR description suggests), add both the "bio" and "isTscMember": true fields to match the pattern of other TSC members.
🤖 Prompt for AI Agents
In config/AMBASSADORS_MEMBERS.json around lines 755 to 803, the Zbigniew
Malcherczyk entry is missing the standard "bio" field and the "isTscMember":
true flag; add a concise "bio" string (one-line summary of role/experience) and
add "isTscMember": true to the JSON object so it matches other TSC member
entries, ensuring proper JSON comma placement and formatting.
🧩 Analysis chain
Verify the duplicate entry claim and validate JSON integrity.
The AI summary states the Zbigniew Malcherczyk entry appears twice, but the provided code shows only one instance (lines 755-803). Verify the file integrity and check whether a duplicate actually exists.
Additionally, validate the JSON structure and count ambassador entries:
🏁 Script executed:
#!/bin/bash
# Description: Validate JSON integrity and verify duplicate entries
# Check JSON validity
jq empty config/AMBASSADORS_MEMBERS.json && echo "✓ JSON is valid" || echo "✗ JSON is invalid"
# Count total entries
echo "Total ambassadors: $(jq 'length' config/AMBASSADORS_MEMBERS.json)"
# Search for Zbigniew Malcherczyk entries
echo "Zbigniew Malcherczyk occurrences:"
jq -r '.[] | select(.name == "Zbigniew Malcherczyk") | .name' config/AMBASSADORS_MEMBERS.json | wc -l
# List all occurrences with their array index
echo "Zbigniew Malcherczyk entry indices:"
jq -r 'to_entries[] | select(.value.name == "Zbigniew Malcherczyk") | "\(.key): \(.value.name)"' config/AMBASSADORS_MEMBERS.jsonLength of output: 134
Now let me verify the entry's structure and check if it has required fields:
🏁 Script executed:
#!/bin/bash
# Description: Inspect entry fields and compare structure
# Extract the Zbigniew Malcherczyk entry (index 11)
echo "=== Zbigniew Malcherczyk entry (index 11) ==="
jq '.[11]' config/AMBASSADORS_MEMBERS.json | head -50
echo ""
echo "=== Field keys in Zbigniew entry ==="
jq '.[11] | keys' config/AMBASSADORS_MEMBERS.json
echo ""
echo "=== Sample entry (index 0) for comparison ==="
jq '.[0]' config/AMBASSADORS_MEMBERS.json | head -50
echo ""
echo "=== Field keys in first entry ==="
jq '.[0] | keys' config/AMBASSADORS_MEMBERS.json
echo ""
echo "=== Check for isTscMember field across all entries ==="
jq '[.[] | select(has("isTscMember")) | .name]' config/AMBASSADORS_MEMBERS.json
echo ""
echo "=== Check for bio field across all entries ==="
jq '[.[] | select(has("bio")) | .name]' config/AMBASSADORS_MEMBERS.jsonLength of output: 4098
Remove the incorrect duplicate claim and address missing data fields.
The verification confirms there is NO duplicate entry—only one Zbigniew Malcherczyk entry exists at index 11. However, the entry is missing fields that are present in 12 out of 13 other ambassador entries:
- Missing
biofield (12/13 entries have this) - Missing
slackfield (present in most other entries)
Additionally, verify whether this entry should include "isTscMember": true, as the PR title references "update latest tsc members list" but currently only 4 of the 13 entries have this flag set.
🤖 Prompt for AI Agents
In config/AMBASSADORS_MEMBERS.json around lines 755 to 803, the Zbigniew
Malcherczyk entry is missing common fields and may need the TSC flag: add a
"bio" string and a "slack" string property to match the other entries (fill with
a short bio and the Slack handle or an empty string if unknown), do not remove
the entry (there is no duplicate), and verify whether Zbigniew should have
"isTscMember": true—if so, add that boolean field; ensure field ordering and
JSON formatting match surrounding entries.
Updated Ambassadors list is available and this PR introduces changes with latest information about Ambassadors list
Summary by CodeRabbit