fix(events): update broken Become Ambassador link on Ambassadors page and broken FAQs link on Events Page #4394
Conversation
…en FAQ link on Events page
SanidhyaMadheshia
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
WalkthroughAdds an ambient TypeScript reference to generated route types and updates two community page links to new document locations. No runtime logic or component behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4394 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4394--asyncapi-website.netlify.app/ |
SanidhyaMadheshia
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
next-env.d.ts (1)
3-3: Remove manual.next/types/routes.d.tsreference
- Delete line 3 in
next-env.d.ts(/// <reference path="./.next/types/routes.d.ts" />)- Instead enable the built-in experimental
typedRoutes: trueflag in your Next.js config (v15.5.2+) or install/configure an official typed-routes plugin to generate route types reliably- If you opt to keep a manual reference, ensure your CI pipeline runs
next build(or otherwise generates.next/types/routes.d.ts) before type-checking- Update the PR title’s subject to start with a lowercase verb for Conventional Commits compliance
pages/community/events/index.tsx (1)
54-56: Switch GitHub branch segment to HEAD for resilienceUsing
blob/HEAD/...avoids future breakage if the default branch renames frommaster.Apply:
- href='https://github.com/asyncapi/community/blob/master/docs/060-meetings-and-communication/MEETINGS_ORGANIZATION.md' + href='https://github.com/asyncapi/community/blob/HEAD/docs/060-meetings-and-communication/MEETINGS_ORGANIZATION.md'If
TextLinkdoesn’t automatically setrel, consider addingrel="noopener noreferrer"alongsidetarget="_blank"for security.pages/community/ambassadors/index.tsx (1)
64-69: Great fix; also prefer HEAD to decouple from branch nameThe updated path resolves the broken link. For future-proofing, use
blob/HEAD/...instead ofblob/master/....- href='https://github.com/asyncapi/community/blob/master/docs/020-governance-and-policies/AMBASSADOR_PROGRAM.md' + href='https://github.com/asyncapi/community/blob/HEAD/docs/020-governance-and-policies/AMBASSADOR_PROGRAM.md'Optional: For consistency, consider updating other GitHub links on this page (e.g., the later “Become an Ambassador now” button) to
blob/HEADas well.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
next-env.d.ts(1 hunks)pages/community/ambassadors/index.tsx(1 hunks)pages/community/events/index.tsx(1 hunks)
3 participants
Fix Broken Links on Ambassadors & Events Pages
Description
This PR fixes two broken links on the AsyncAPI website:
Resolves issue(s)
Resolves : #4382
Resolves : #4384
Ambassadors Page
Fixed the broken "Become AsyncAPI Ambassador" button.
Previously pointed to an outdated/non-existent path.
Updated to the correct Ambassador Program page.
Events Page
Fixed the broken "Read FAQ" link.
Previously pointed to an outdated/non-existent path.
Updated to the correct page.
Old links:
https://github.com/asyncapi/community/blob/master/MEETINGS_ORGANIZATION.md
https://github.com/asyncapi/community/blob/master/docs/050-mentorship-program/ambassador-program/AMBASSADOR_PROGRAM.md
Updated to:
https://github.com/asyncapi/community/blob/master/docs/060-meetings-and-communication/MEETINGS_ORGANIZATION.md
https://github.com/asyncapi/community/blob/master/docs/020-governance-and-policies/AMBASSADOR_PROGRAM.md
Preview
On Clicking now goes to
and
now goes to
Summary by CodeRabbit
Bug Fixes
Chores