Skip to content

Conversation

@asyncapi-bot
Copy link
Contributor

@asyncapi-bot asyncapi-bot commented Aug 26, 2025

Updated Maintainers list is available and this PR introduces changes with latest information about Maintainers

Summary by CodeRabbit

  • Chores
    • Updated the maintainers list to include a new maintainer for the generator repository.
    • Improves project stewardship by clarifying ownership, contact points, and triage responsibilities.
    • Ensures better support coverage and continuity for repository maintenance.
    • No changes to application behavior or user-facing functionality.

@netlify
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit f480f4d
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/68ad718170a91b00088b1625
😎 Deploy Preview https://deploy-preview-4360--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 26, 2025

Walkthrough

Adds a new maintainer object to config/MAINTAINERS.json with fields: github, isTscMember, repos, and twitter. The entry omits name and githubID fields. No other modifications.

Changes

Cohort / File(s) Summary of Changes
Maintainers config
config/MAINTAINERS.json
Appended a maintainer object: {"github":"Adi-204","isTscMember":false,"repos":["generator"],"twitter":"AdiBoghawala"}. Note: lacks typical "name" and "githubID" fields; no other entries altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

autoapproved, autoupdate

Suggested reviewers

  • derberg
  • anshgoyalevil
  • akshatnema
  • sambhavgupta0705

Poem

A nibble of JSON, hop-hop—neat,
A name-less carrot in the maintainers’ sheet.
Git burrow updated, fields a bit spare,
I twitch my whiskers—double-check with care.
Thump of approval, light as air—
Merge me softly, I’ll be there. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-tscmembers-350f57cc24a51571976b22be773f2fe3a04d2437

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fa24665) to head (f480f4d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          778       778           
  Branches       144       144           
=========================================
  Hits           778       778           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asyncapi-bot
Copy link
Contributor Author

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 35
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-4360--asyncapi-website.netlify.app/

@asyncapi-bot asyncapi-bot merged commit e19473b into master Aug 26, 2025
34 of 35 checks passed
@asyncapi-bot asyncapi-bot deleted the update-tscmembers-350f57cc24a51571976b22be773f2fe3a04d2437 branch August 26, 2025 08:38
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
config/MAINTAINERS.json (1)

975-982: Maintain ordering consistency: place new entry with the A… names instead of appending to the end

The list appears broadly grouped/alphabetized by name. Appending an “A…” maintainer at the end reduces readability and makes future diffs noisier. Please move the new object to the appropriate alphabetical position (near other A-names) once the "name" is added.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fa24665 and f480f4d.

📒 Files selected for processing (1)
  • config/MAINTAINERS.json (1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Automerge PR autoapproved by a bot
  • GitHub Check: Test NodeJS PR - windows-latest
  • GitHub Check: Lighthouse CI

Comment on lines +974 to +976
},
{
"github": "Adi-204",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

JSON is invalid: missing comma between array items

There must be a comma after the closing brace of the previous maintainer object to separate it from the newly added object.

Apply this minimal fix:

-        "githubID": 105683440
-    }
+        "githubID": 105683440
+    },

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In config/MAINTAINERS.json around lines 974 to 976, the JSON is invalid because
the previous maintainer object is missing a trailing comma before the new object
starting at line 976; add a comma after the closing brace of the previous array
item so each object in the array is properly separated and the file parses as
valid JSON.

Comment on lines +975 to 982
{
"github": "Adi-204",
"isTscMember": false,
"repos": [
"generator"
],
"twitter": "AdiBoghawala"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

New maintainer entry lacks commonly used fields (name, githubID); verify schema requirements

Most entries include "name" and "githubID" and often "availableForHire", "slack", and "linkedin". If downstream rendering or tooling expects "name" and "githubID", omitting them may break UI features (avatars, sorting) or automation. Please confirm the required shape for this file and populate missing fields.

If helpful, run this script to fetch canonical data for github handle Adi-204 and identify any other entries missing key fields:

Once you have the values, update the object accordingly. Example structure (replace placeholders):

-    {
-        "github": "Adi-204",
-        "isTscMember": false,
-        "repos": [
-            "generator"
-        ],
-        "twitter": "AdiBoghawala"
-    }
+    {
+        "name": "REPLACE_WITH_NAME",
+        "github": "Adi-204",
+        "linkedin": "REPLACE_IF_AVAILABLE",
+        "slack": "REPLACE_IF_AVAILABLE",
+        "twitter": "AdiBoghawala",
+        "availableForHire": REPLACE_WITH_TRUE_OR_FALSE,
+        "isTscMember": false,
+        "repos": ["generator"],
+        "githubID": REPLACE_WITH_NUMERIC_ID
+    }

I can fill these fields for you if you confirm they’re required by the site.


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Validate JSON
jq -e . config/MAINTAINERS.json >/dev/null && echo "JSON OK"

# 2) List entries missing name or githubID
echo "Entries missing name or githubID:"
jq -r '.[] | select((has("name")|not) or (has("githubID")|not)) | [.github, (."name"//"__no_name__"), (."githubID"//"__no_id__")] | @tsv' config/MAINTAINERS.json

# 3) Fetch GitHub metadata for Adi-204
echo "GitHub API lookup for Adi-204:"
curl -s https://api.github.com/users/Adi-204 | jq '{login, id, name}'

Length of output: 458


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Locate the MAINTAINERS file
files=$(fd -HI MAINTAINERS.json || true)
if [ -z "$files" ]; then
  echo "No MAINTAINERS.json file found with fd."
  # Try JSON files containing 'Adi-204'
  files=$(grep -RIl "Adi-204" . | grep -E "\.json$" || true)
fi

echo "Candidate files:"
echo "$files"

# Use the first candidate
file=$(echo "$files" | head -n1)
echo "Using file: $file"

# Validate JSON
jq -e . "$file" >/dev/null && echo "JSON OK"

# List entries missing name or githubID
echo "Entries missing name or githubID:"
jq -r '.[] | select((has("name")|not) or (has("githubID")|not)) | [.github, (."name"//"__no_name__"), (."githubID"//"__no_id__")] | @tsv' "$file"

# Show entry for Adi-204
echo "Entry for Adi-204:"
jq -r '.[] | select(.github=="Adi-204")' "$file"

Length of output: 926


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Fetching GitHub metadata for Adi-204:"
curl -s https://api.github.com/users/Adi-204 | jq '{login, id, name}'

Length of output: 247


Add missing maintainer fields for Adi-204

The entry for Adi-204 in config/MAINTAINERS.json is missing the required "name" and "githubID" properties. We fetched the GitHub metadata and verified:

{
  "login":  "Adi-204",
  "id":     114283933,
  "name":   "Adi Boghawala"
}

Please update the object accordingly. For example:

--- a/config/MAINTAINERS.json
+++ b/config/MAINTAINERS.json
@@ -972,9 +972,14 @@
     {
-        "github": "Adi-204",
-        "isTscMember": false,
-        "repos": [
-            "generator"
-        ],
-        "twitter": "AdiBoghawala"
+        "name":       "Adi Boghawala",
+        "github":     "Adi-204",
+        "githubID":   114283933,
+        "twitter":    "AdiBoghawala",
+        "isTscMember": false,
+        "repos":      ["generator"]
     }

• If your project tracks additional fields like "availableForHire", "linkedin", or "slack", please add them here as well.
• Let me know if you’d like me to fill in any of those optional properties.

🤖 Prompt for AI Agents
In config/MAINTAINERS.json around lines 975 to 982, the maintainer object for
"Adi-204" is missing required "name" and "githubID" properties; update the
object to include "name": "Adi Boghawala" and "githubID": 114283933 and retain
existing fields ("github", "isTscMember", "repos", "twitter"); optionally add
any additional tracked fields like "availableForHire", "linkedin", or "slack" if
applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants