-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(community): update latest maintainers list #4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(community): update latest maintainers list #4360
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughAdds a new maintainer object to config/MAINTAINERS.json with fields: github, isTscMember, repos, and twitter. The entry omits name and githubID fields. No other modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4360--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
config/MAINTAINERS.json (1)
975-982: Maintain ordering consistency: place new entry with the A… names instead of appending to the endThe list appears broadly grouped/alphabetized by name. Appending an “A…” maintainer at the end reduces readability and makes future diffs noisier. Please move the new object to the appropriate alphabetical position (near other A-names) once the "name" is added.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
config/MAINTAINERS.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
| }, | ||
| { | ||
| "github": "Adi-204", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON is invalid: missing comma between array items
There must be a comma after the closing brace of the previous maintainer object to separate it from the newly added object.
Apply this minimal fix:
- "githubID": 105683440
- }
+ "githubID": 105683440
+ },Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In config/MAINTAINERS.json around lines 974 to 976, the JSON is invalid because
the previous maintainer object is missing a trailing comma before the new object
starting at line 976; add a comma after the closing brace of the previous array
item so each object in the array is properly separated and the file parses as
valid JSON.
| { | ||
| "github": "Adi-204", | ||
| "isTscMember": false, | ||
| "repos": [ | ||
| "generator" | ||
| ], | ||
| "twitter": "AdiBoghawala" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
New maintainer entry lacks commonly used fields (name, githubID); verify schema requirements
Most entries include "name" and "githubID" and often "availableForHire", "slack", and "linkedin". If downstream rendering or tooling expects "name" and "githubID", omitting them may break UI features (avatars, sorting) or automation. Please confirm the required shape for this file and populate missing fields.
If helpful, run this script to fetch canonical data for github handle Adi-204 and identify any other entries missing key fields:
Once you have the values, update the object accordingly. Example structure (replace placeholders):
- {
- "github": "Adi-204",
- "isTscMember": false,
- "repos": [
- "generator"
- ],
- "twitter": "AdiBoghawala"
- }
+ {
+ "name": "REPLACE_WITH_NAME",
+ "github": "Adi-204",
+ "linkedin": "REPLACE_IF_AVAILABLE",
+ "slack": "REPLACE_IF_AVAILABLE",
+ "twitter": "AdiBoghawala",
+ "availableForHire": REPLACE_WITH_TRUE_OR_FALSE,
+ "isTscMember": false,
+ "repos": ["generator"],
+ "githubID": REPLACE_WITH_NUMERIC_ID
+ }I can fill these fields for you if you confirm they’re required by the site.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Validate JSON
jq -e . config/MAINTAINERS.json >/dev/null && echo "JSON OK"
# 2) List entries missing name or githubID
echo "Entries missing name or githubID:"
jq -r '.[] | select((has("name")|not) or (has("githubID")|not)) | [.github, (."name"//"__no_name__"), (."githubID"//"__no_id__")] | @tsv' config/MAINTAINERS.json
# 3) Fetch GitHub metadata for Adi-204
echo "GitHub API lookup for Adi-204:"
curl -s https://api.github.com/users/Adi-204 | jq '{login, id, name}'Length of output: 458
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate the MAINTAINERS file
files=$(fd -HI MAINTAINERS.json || true)
if [ -z "$files" ]; then
echo "No MAINTAINERS.json file found with fd."
# Try JSON files containing 'Adi-204'
files=$(grep -RIl "Adi-204" . | grep -E "\.json$" || true)
fi
echo "Candidate files:"
echo "$files"
# Use the first candidate
file=$(echo "$files" | head -n1)
echo "Using file: $file"
# Validate JSON
jq -e . "$file" >/dev/null && echo "JSON OK"
# List entries missing name or githubID
echo "Entries missing name or githubID:"
jq -r '.[] | select((has("name")|not) or (has("githubID")|not)) | [.github, (."name"//"__no_name__"), (."githubID"//"__no_id__")] | @tsv' "$file"
# Show entry for Adi-204
echo "Entry for Adi-204:"
jq -r '.[] | select(.github=="Adi-204")' "$file"Length of output: 926
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Fetching GitHub metadata for Adi-204:"
curl -s https://api.github.com/users/Adi-204 | jq '{login, id, name}'Length of output: 247
Add missing maintainer fields for Adi-204
The entry for Adi-204 in config/MAINTAINERS.json is missing the required "name" and "githubID" properties. We fetched the GitHub metadata and verified:
{
"login": "Adi-204",
"id": 114283933,
"name": "Adi Boghawala"
}Please update the object accordingly. For example:
--- a/config/MAINTAINERS.json
+++ b/config/MAINTAINERS.json
@@ -972,9 +972,14 @@
{
- "github": "Adi-204",
- "isTscMember": false,
- "repos": [
- "generator"
- ],
- "twitter": "AdiBoghawala"
+ "name": "Adi Boghawala",
+ "github": "Adi-204",
+ "githubID": 114283933,
+ "twitter": "AdiBoghawala",
+ "isTscMember": false,
+ "repos": ["generator"]
}• If your project tracks additional fields like "availableForHire", "linkedin", or "slack", please add them here as well.
• Let me know if you’d like me to fill in any of those optional properties.
🤖 Prompt for AI Agents
In config/MAINTAINERS.json around lines 975 to 982, the maintainer object for
"Adi-204" is missing required "name" and "githubID" properties; update the
object to include "name": "Adi Boghawala" and "githubID": 114283933 and retain
existing fields ("github", "isTscMember", "repos", "twitter"); optionally add
any additional tracked fields like "availableForHire", "linkedin", or "slack" if
applicable.
Updated Maintainers list is available and this PR introduces changes with latest information about Maintainers
Summary by CodeRabbit