-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update meetings.json and newsrooom_videos.json #4334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asyncapi-bot
merged 1 commit into
master
from
update-meetings/8d8c8298c233fbc695c7f083226a431cc3be27c3
Aug 19, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify chronological ordering and detect duplicates.
Although the new date looks correctly placed, please run the checks below to ensure global ordering and no duplicate times/URLs/calLinks crept in.
🏁 Script executed:
Length of output: 210
#!/bin/bash
set -euo pipefail
FILE="config/meetings.json"
echo "1) Validating JSON…"
jq empty "$FILE"
echo
echo "2) Checking required keys for each entry…"
missing=$(jq -r '
to_entries[]
| select(
(.value | has("title") | not)
or (.value | has("calLink") | not)
or (.value | has("url") | not)
or (.value | has("banner") | not)
or (.value | has("date") | not)
)
| "Entry index (.key) is missing one or more of: title, calLink, url, banner, date"
' "$FILE")
if [ -n "$missing" ]; then
echo "$missing"
exit 1
else
echo "All entries have required keys."
fi
echo
echo "3) Listing dates with original index:"
jq -r 'to_entries[] | "(.key): (.value.date)"' "$FILE"
echo
echo "4) Verifying sort order:"
mapfile -t dates < <(jq -r '.[].date' "$FILE")
mapfile -t sorted < <(printf "%s\n" "${dates[@]}" | sort)
if [ "${dates[]}" = "${sorted[]}" ]; then
echo "Dates are sorted ascending."
else
echo "Dates are NOT sorted ascending."
echo "Actual | Expected(sorted)"
paste <(printf "%s\n" "${dates[@]}") <(printf "%s\n" "${sorted[@]}") | sed 's/\t/ | /'
exit 1
fi
echo
echo "5) Detecting duplicates in date, url, and calLink:"
for key in date url calLink; do
echo "- $key duplicates:"
dup=$(jq -r --arg k "$key" '.[].[$k]' "$FILE" | sort | uniq -d)
if [ -n "$dup" ]; then
echo "$dup"
exit 1
else
echo " None"
fi
done
#!/bin/bash
set -euo pipefail
FILE="config/meetings.json"
echo "1) JSON validity check:"
if jq empty "$FILE" >/dev/null 2>&1; then
echo " ✔ Valid JSON"
else
echo " ✖ Invalid JSON"
exit 1
fi
echo
echo "2) Required keys per entry:"
missing=$(jq -r '
to_entries[]
| select(
(.value | has("title") | not)
or (.value | has("calLink") | not)
or (.value | has("url") | not)
or (.value | has("banner") | not)
or (.value | has("date") | not)
)
| "Entry index (.key) missing one or more of: title, calLink, url, banner, date"
' "$FILE")
if [ -n "$missing" ]; then
echo " ✖ Found missing keys:"
echo "$missing"
exit 1
else
echo " ✔ All entries have required keys."
fi
echo
echo "3) Listing dates with their indices:"
jq -r 'to_entries[] | " [(.key)] (.value.date)"' "$FILE"
echo
echo "4) Sort order check:"
mapfile -t dates < <(jq -r '.[].date' "$FILE")
mapfile -t sorted < <(printf "%s\n" "${dates[@]}" | sort)
if [ "${dates[]}" = "${sorted[]}" ]; then
echo " ✔ Dates are sorted ascending."
else
echo " ✖ Dates are NOT sorted ascending."
echo " Actual | Expected(sorted)"
paste <(printf "%s\n" "${dates[@]}") <(printf "%s\n" "${sorted[@]}") | sed 's/\t/ | /'
exit 1
fi
echo
echo "5) Duplicate detection (date, url, calLink):"
for key in date url calLink; do
echo " - $key duplicates:"
dup=$(jq -r --arg k "$key" '.[].[$k]' "$FILE" | sort | uniq -d)
if [ -n "$dup" ]; then
echo " ✖ $dup"
exit 1
else
echo " ✔ None"
fi
done
echo
echo "No ordering issues or duplicates detected."
🏁 Script executed:
Length of output: 657
🏁 Script executed:
Length of output: 5865
Fix chronological ordering in config/meetings.json
Manual inspection shows the
meetings.jsonarray is not strictly sorted by the"date"field. Please reorder the entries so that each event’s ISO-8601 timestamp ascends. For example:2025-05-15T16:00:00.000Z(index 2) should come before2025-05-20T15:00:00.000Z(index 1)2025-05-29T10:00:00.000Z(index 6) should come before2025-05-29T16:00:00.000Z(index 3)2025-06-17T15:00:00.000Z(index 10) should come before2025-06-19T16:00:00.000Z(index 8) and2025-06-24T14:00:00.000Z(index 9)2025-07-03T16:00:00.000Z(index 14) should come before2025-07-08T14:00:00.000Z(index 12) and2025-07-15T15:00:00.000Z(index 13)2025-07-29T13:00:00.000Z(index 16) should come before2025-07-29T15:00:00.000Z(index 15)2025-08-07T16:00:00.000Z(index 18) should come before2025-08-12T15:00:00.000Z(index 17)No duplicate
date,url, orcalLinkvalues were detected. Once reordered, the file will pass JSON-sort and duplication checks.🤖 Prompt for AI Agents