chore: update meetings.json and newsrooom_videos.json #4320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
asyncapi-bot-eve
approved these changes
Aug 9, 2025
Contributor
WalkthroughA new meeting entry was added to Changes
Sequence Diagram(s)Not applicable: Only static data (configuration) updates, no control flow or feature logic changes. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4320 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4320--asyncapi-website.netlify.app/ |
asyncapi-bot
deleted the
update-meetings/c426570db7cbc61c3e547a28eeaa7a4b11e2f21f
branch
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: asyncapi-bot
PR: asyncapi/website#0
File: :0-0
Timestamp: 2025-02-18T12:07:42.211Z
Learning: The following PR commands are supported in the asyncapi/website repository:
- `/please-take-a-look` or `/ptal`: Requests attention from reviewers who haven't reviewed the PR
- `/ready-to-merge` or `/rtm`: Triggers automerge when all conditions are met
- `/do-not-merge` or `/dnm`: Blocks automerge even if all conditions are met
- `/autoupdate` or `/au`: Adds autoupdate label to keep PR in sync with target branch
- `/update` or `/u`: One-time update of PR with latest changes from target branch
Learnt from: akshatnema
PR: asyncapi/website#3265
File: tests/fixtures/toolsObjectData.js:51-52
Timestamp: 2024-10-09T17:35:36.557Z
Learning: When reviewing code in the 'asyncapi/website' repository, akshatnema prefers that I do not provide committable code suggestions.
Learnt from: anshgoyalevil
PR: asyncapi/website#3557
File: scripts/markdown/check-editlinks.js:58-59
Timestamp: 2025-01-08T15:15:00.759Z
Learning: In the AsyncAPI codebase, batch processing operations (like in the Dashboard script and check-editlinks.js) follow a sequential pattern using await in loops, which is the preferred approach for maintaining consistency across the codebase.
📚 Learning: 2025-06-03T06:48:09.304Z
Learnt from: iambami
PR: asyncapi/website#4111
File: markdown/blog/community-spotlight-aayush.md:3-3
Timestamp: 2025-06-03T06:48:09.304Z
Learning: For AsyncAPI community spotlight blog posts, the frontmatter date should reflect the actual publication date, not the month being highlighted in the spotlight. For example, a "May Community Spotlight" can be published in June with a June date in the frontmatter.
Applied to files:
config/meetings.json
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/meetings.json (1)
148-155: Mentorship Wrap-Up entry validated
- All required fields (title, calLink, url, date) are present and non-empty.
- Date is in valid ISO-8601 UTC format with “.000Z”.
- Title has no leading or trailing whitespace.
- Calendar link responds with HTTP 200.
- Banner URL returns HTTP 302 redirect (expected for GitHub assets).
No further changes needed.
Comment on lines
+20
to
+25
| { | ||
| "image_url": "https://i.ytimg.com/vi/FkGnFqMTj88/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting, Tuesday July 15th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1969.", | ||
| "videoId": "FkGnFqMTj88" | ||
| }, |
Contributor
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
New video entry added: validate thumbnail/videoId pairing and title punctuation consistency.
- The image URL and videoId match (FkGnFqMTj88). Good.
- Nitpick: titles across this file inconsistently place spaces before commas (e.g., "Meeting , Tuesday ..."). Consider standardizing to no space before commas for consistency.
Use this script to verify that each entry’s image_url (i.ytimg.com/vi//...) matches its videoId and to flag titles with a space before commas:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import json, re, sys
from urllib.parse import urlparse
with open('config/newsroom_videos.json') as f:
data = json.load(f)
problems = 0
for i, e in enumerate(data):
vid = e.get('videoId', '')
img = e.get('image_url', '')
title = e.get('title', '')
# Check i.ytimg.com videoId match
if img and 'i.ytimg.com' in img:
parts = urlparse(img).path.strip('/').split('/')
# Expect ['vi', '<videoId>', 'hqdefault.jpg']
if len(parts) >= 2 and parts[0] == 'vi':
if parts[1] != vid:
print(f"[mismatch] Entry {i}: image_url videoId '{parts[1]}' != videoId '{vid}'")
problems += 1
# Flag titles with space before comma
if re.search(r'\s+,', title):
print(f"[punctuation] Entry {i}: title has space before comma -> '{title}'")
# Specifically assert the new entry exists and is consistent
target = [e for e in data if e.get('videoId') == 'FkGnFqMTj88']
assert target, "New video entry with videoId FkGnFqMTj88 not found."
print("Check complete.")
sys.exit(problems)
PY
echo "HEAD request for the new thumbnail..."
curl -sI "https://i.ytimg.com/vi/FkGnFqMTj88/hqdefault.jpg" | head -n1 || trueLength of output: 558
Punctuation inconsistency in config/newsroom_videos.json
The new entry’s thumbnail/videoId pairing is correct (HTTP 200 on the HEAD request), but several titles across this file include a space before the comma. Please standardize by removing the space before each comma:
• Entry 0: “AsyncAPI Community WG Meeting , Tuesday July 29th 2025”
• Entry 1: “First Meeting of New Governance Board , Tuesday July 29th 2025”
• Entry 2: “AsyncAPI Community WG Meeting , Tuesday July 29th 2025”
Action: edit these titles (and any others) to use “…Meeting, Tuesday…” (no space before commas).
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 20 to 25, several video title
entries have an incorrect space before commas in the titles. Locate all titles
with a space before the comma, such as "Meeting , Tuesday", and remove the space
so it reads "Meeting, Tuesday" to ensure consistent punctuation formatting
throughout the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores