chore: update meetings.json and newsrooom_videos.json #4317
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThis update removes the "Marketing WG Meeting" scheduled for 2025-04-29 from the meetings configuration. In the newsroom videos configuration, it removes a video for the "AsyncAPI Community WG Meeting" (July 15th, 2025) and adds a new video for the "AsyncAPI Design WG Meeting" (June 17th, 2025). No other entries were changed. Changes
Sequence Diagram(s)Not applicable: Changes are limited to static data updates in configuration files. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/newsroom_videos.json (1)
27-30: Maintain title-punctuation consistency across entriesEarlier items place a space before the comma in
"AsyncAPI … Meeting , Tuesday …", whereas the newly-added entry omits that extra space ("Meeting, Tuesday …"). Pick one style and apply it uniformly so the newsroom list doesn’t look accidentally inconsistent.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(0 hunks)config/newsroom_videos.json(1 hunks)
💤 Files with no reviewable changes (1)
- config/meetings.json
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: asyncapi-bot
PR: asyncapi/website#0
File: :0-0
Timestamp: 2025-02-18T12:07:42.211Z
Learning: The following PR commands are supported in the asyncapi/website repository:
- `/please-take-a-look` or `/ptal`: Requests attention from reviewers who haven't reviewed the PR
- `/ready-to-merge` or `/rtm`: Triggers automerge when all conditions are met
- `/do-not-merge` or `/dnm`: Blocks automerge even if all conditions are met
- `/autoupdate` or `/au`: Adds autoupdate label to keep PR in sync with target branch
- `/update` or `/u`: One-time update of PR with latest changes from target branch
Learnt from: akshatnema
PR: asyncapi/website#3265
File: tests/fixtures/toolsObjectData.js:51-52
Timestamp: 2024-10-09T17:35:36.557Z
Learning: When reviewing code in the 'asyncapi/website' repository, akshatnema prefers that I do not provide committable code suggestions.
Learnt from: anshgoyalevil
PR: asyncapi/website#3557
File: scripts/markdown/check-editlinks.js:58-59
Timestamp: 2025-01-08T15:15:00.759Z
Learning: In the AsyncAPI codebase, batch processing operations (like in the Dashboard script and check-editlinks.js) follow a sequential pattern using await in loops, which is the preferred approach for maintaining consistency across the codebase.
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/newsroom_videos.json (1)
27-30: Double-check metadata accuracy (image URL ↔ videoId ↔ issue link)Before merging, please verify that
• the thumbnail URLuVAurockaPcmatches the same YouTube ID,
• thevideoIdreally points to the Design WG meeting on 17 Jun 2025, and
• issue #1935 indeed tracks that recording.
Small mismatches here break embeds or mislead viewers.
asyncapi-bot
deleted the
update-meetings/80509d5d71232fe8fbd808e5bf2ee81111599a44
branch
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4317--asyncapi-website.netlify.app/ |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit