chore: update meetings.json and newsrooom_videos.json #4260
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughA new entry for the AsyncAPI Community WG Meeting on July 15th, 2025, was added to the start of the newsroom videos JSON configuration, while the oldest entry for the June 3rd, 2025 meeting was removed from the end. No other changes were made. Changes
Sequence Diagram(s)sequenceDiagram
participant Maintainer
participant newsroom_videos.json
Maintainer->>newsroom_videos.json: Add new video entry (July 15, 2025) at start
Maintainer->>newsroom_videos.json: Remove oldest video entry (June 3, 2025) from end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4260 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
config/newsroom_videos.json (1)
15-24: Duplicate “Design WG Meeting, June 17 2025” entryLines 15-24 contain two identical objects (same title, image, issue link, and
videoId). This duplication predates the current change but results in the same video showing twice. Consider removing one copy for a cleaner list.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/newsroom_videos.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: asyncapi-bot
PR: asyncapi/website#0
File: :0-0
Timestamp: 2025-02-18T12:07:42.211Z
Learning: The following PR commands are supported in the asyncapi/website repository:
- `/please-take-a-look` or `/ptal`: Requests attention from reviewers who haven't reviewed the PR
- `/ready-to-merge` or `/rtm`: Triggers automerge when all conditions are met
- `/do-not-merge` or `/dnm`: Blocks automerge even if all conditions are met
- `/autoupdate` or `/au`: Adds autoupdate label to keep PR in sync with target branch
- `/update` or `/u`: One-time update of PR with latest changes from target branch
Learnt from: akshatnema
PR: asyncapi/website#3378
File: scripts/markdown/check-markdown.js:1-1
Timestamp: 2024-11-25T18:41:29.632Z
Learning: When updating workflows for the AsyncAPI website repository, use `.github/workflows/if-nodejs-pr-testing.yml` to include environment variables and secrets for Node.js PR testing.
Learnt from: iambami
PR: asyncapi/website#4111
File: markdown/blog/community-spotlight-aayush.md:3-3
Timestamp: 2025-06-03T06:48:09.304Z
Learning: For AsyncAPI community spotlight blog posts, the frontmatter date should reflect the actual publication date, not the month being highlighted in the spotlight. For example, a "May Community Spotlight" can be published in June with a June date in the frontmatter.
Learnt from: akshatnema
PR: asyncapi/website#3265
File: tests/fixtures/toolsObjectData.js:51-52
Timestamp: 2024-10-09T17:35:36.557Z
Learning: When reviewing code in the 'asyncapi/website' repository, akshatnema prefers that I do not provide committable code suggestions.
Learnt from: anshgoyalevil
PR: asyncapi/website#3557
File: scripts/markdown/check-editlinks.js:58-59
Timestamp: 2025-01-08T15:15:00.759Z
Learning: In the AsyncAPI codebase, batch processing operations (like in the Dashboard script and check-editlinks.js) follow a sequential pattern using await in loops, which is the preferred approach for maintaining consistency across the codebase.
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/newsroom_videos.json (1)
3-6: Metadata looks goodThumbnail, title text, and
videoIdfollow existing conventions and keep the array in reverse-chronological order.
| { | ||
| "image_url": "https://i.ytimg.com/vi/FkGnFqMTj88/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting, Tuesday July 15th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1969.", | ||
| "videoId": "FkGnFqMTj88" | ||
| }, |
There was a problem hiding this comment.
Broken description URL – trailing period causes 404
The description value ends with a literal . (…/issues/1969.). Markdown/HTML parsers treat the dot as part of the URL, so the rendered link is broken.
Please strip the trailing period (or place it outside the quotes) to ensure the link resolves correctly. The same issue appears in older entries and may warrant a quick sweep.
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 2 to 7, the description field
contains a URL ending with a trailing period, causing broken links. Remove the
trailing period from the URL string in the description field to ensure the link
resolves correctly. Also, review older entries for similar trailing periods in
URLs and fix them similarly.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4260--asyncapi-website.netlify.app/ |
|
/update |
|
/rtm |
akshatnema
deleted the
update-meetings/62fab51cae66b1fb0d46a8846a1c37aded4d17ec
branch
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores