chore: update meetings.json and newsrooom_videos.json #4206
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThree existing entries in the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to static JSON data updates. Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4206 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
config/newsroom_videos.json (3)
15-18: Strip the trailing period from the GitHub-issue URL & verify the duplicate-meeting entry
"description"ends with a.which becomes part of the string and breaks the link when rendered.
Also note that this entry shares the same title/date as the entry starting at line 21 but carries a differentvideoId. If both videos really belong to the same meeting, consider clarifying the title (e.g., “part 1/part 2”) to avoid confusion.- "description": "https://github.com/asyncapi/community/issues/1919.", + "description": "https://github.com/asyncapi/community/issues/1919"
21-24: Same link-punctuation issue & potential duplicateThe period at the end of the URL must be removed for a valid hyperlink.
Because this object’s title/date duplicates the previous one, please double-check whether the duplication is intentional.- "description": "https://github.com/asyncapi/community/issues/1919.", + "description": "https://github.com/asyncapi/community/issues/1919"
27-30: Broken URL and inconsistent title format
- Remove the trailing
.from the URL.- For consistency with the other items, append the meeting date to the title (e.g., “AsyncAPI Design WG Meeting, Thursday 2025”).
- "description": "https://github.com/asyncapi/community/issues/1908.", + "description": "https://github.com/asyncapi/community/issues/1908"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (8)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - ubuntu-latest
- GitHub Check: Lighthouse CI
asyncapi-bot
deleted the
update-meetings/79919cb48cd51561a71ce3b6a1ad08f44dac7931
branch
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit