-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update tools.json #4186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tools.json #4186
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThis update modifies three JSON configuration files by swapping and reorganizing entries related to tool metadata, repository URLs, descriptions, and technology tags. No code or exported entities are changed; only configuration data is updated for accuracy and consistency across technology and tool listings. Changes
Sequence Diagram(s)sequenceDiagram
participant ConfigMaintainer
participant JSONConfigFiles
ConfigMaintainer->>JSONConfigFiles: Update tool and technology entries
JSONConfigFiles-->>ConfigMaintainer: Store new metadata and ordering
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (2)
config/tools-automated.json (2)
929-949:⚠️ Potential issueCritical: Incorrect language filter for Java Spring Template.
Using
"javascript"here will break language-based filtering. It must be"Java".Apply this diff:
- "language": [ - "javascript" - ], + "language": [ + "Java" + ],
951-969:⚠️ Potential issueCritical: Incorrect language filter for Java Template.
Same issue: the language filter is set to
"javascript"instead of"Java".- "language": [ - "javascript" - ], + "language": [ + "Java" + ],
🧹 Nitpick comments (7)
config/tools-automated.json (7)
75-94: Verify Zod Sockets categorization and tag consistency.Categories
code-first,dsl,frameworkmust align with the taxonomy in your schema. Double-check technology tag casing (e.g., “Node.js”) and ensure categories are singular vs. plural consistently across all entries.
399-420: Review DSL section entry for Zod Sockets.Moving Zod Sockets into DSL is logical, but verify technology and category tags (“dsl”, “framework”) match your DSL taxonomy and that duplication across sections is acceptable.
534-552: Capitalize language names consistently.
"language": "kotlin"should match the style of other entries (e.g.,"Java","TypeScript"). Update to"Kotlin".
629-645: Add missingwebsiteUrlfor AsyncAPI Validation.This validator entry lacks a
websiteUrl. If a homepage exists, include it for consistency.
652-669: Standardizejasyncapicmpnaming and casing.Tool title uses lowercase; consider Title Case (
Jasyncapicmp) orjAsyncAPICmpper naming conventions. Confirm technology tags match elsewhere.
718-742: Deduplicate ZenWave SDK in CLIs.ZenWave SDK appears again under CLIs—consider a shared definition or a reference mechanism to avoid drift.
849-864: Review duplicateasyncapi-previewentries.Two preview entries may confuse users. Consider merging or clarifying the difference between official and test forks.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
config/all-tags.json(1 hunks)config/tools-automated.json(26 hunks)config/tools.json(9 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (8)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - ubuntu-latest
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (18)
config/all-tags.json (1)
281-289: Approve tech tag swap for JetBrains and SmartPaste
The names of the two adjacent entries have been swapped correctly, and their color/borderColor values remain consistent with other configurations (e.g., config/tools.json).config/tools.json (4)
1687-1689: Review swapped metadata for “GitHub Action for Generator” — description & repoUrl
The first action’sdescriptionis nownulland itsrepoUrlpoints to the marketplace-validations repository. Ensure these reflect the intended mapping for that GitHub Action.
1701-1703: Confirm category tag consistency for “GitHub Action for Generator”
The singulargithub-actionand pluralgithub-actionstags have been applied to the two respective entries. Verify that filters and UI components handle both forms correctly or consider normalizing them.
2330-2333: Review CLI repo URL swap — official vs fork
The first AsyncAPI CLI entry now points to the officialasyncapi/clirepo, and the second tohkirat/asyncapi-fork. Confirm that the fork entry is required and correctly categorized.
2553-2556: Verifyasyncapi-previewrepoUrl updates
The firstasyncapi-previewextension now references the official AsyncAPI org repository; the second points to a testing repository (Savio629/testing2). Confirm the testing entry’s purpose and consider renaming or documenting it to avoid confusion.Also applies to: 2579-2582
config/tools-automated.json (13)
53-58: Validate LEGO AsyncAPI.NET entry and its description.Ensure that this LEGO org SDK entry is intended as the upstream package, and that its description clearly differentiates it from the ByteBardOrg fork. Confirm links resolve and no unintended duplication exists.
115-136: Confirm ByteBardOrg AsyncAPI.NET fork metadata.The ByteBardOrg SDK entry’s description and URLs should clearly signal its “official fork” status and avoid ambiguity. Verify that this entry is distinct from the LEGO version.
136-158: Ensure SIO-AsyncAPI placement is intentional.SIO-AsyncAPI now appears under Code-first tools (in addition to APIs). Validate that this duplication is desired and that its
docsUrlis required here.
489-503: Approve CLI Action metadata swap.Description, repo URL, category (
github-actions), and owner flag look correct for the official AsyncAPI CLI action.
511-531: Check Mokapi tool metadata.Confirm that
Go/Golangis the canonical language tag (others use “Go” or “Go/Golang”) and that the URLs (websiteUrl,docsUrl,repoUrl) are correct.
672-689: Approve AsyncAPI Diff entry.Metadata and owner flag look accurate; no actionable changes.
763-768: Verify forked AsyncAPI CLI URL.This entry points to a personal fork. Ensure that linking to a fork is intended, and that
isAsyncAPIOwner: falseis correct.
810-825: Confirm officialasyncapi-previewownership.
isAsyncAPIOwner: trueis correct for the official VSCode extension—just a sanity check on the repo URL.
828-846: Validate jAsyncAPI IDEA plugin metadata.Ensure
websiteUrl,docsUrl, andrepoUrlare all reachable and that the description accurately captures the plugin’s purpose.
893-909: Approve Node.js Websockets Template.All fields and categories align with generator‐template standards.
911-927: Approve HTML Template entry.Description, repo link, and tags correctly reflect the HTML generator template.
971-987: Approve Node.js Multiprotocol Template.Metadata and categories are consistent and accurate.
1015-1027: Confirm official CLI entry under Others.This mirrors the primary CLI entry with correct ownership and URL—no further changes needed.
| "title": "GitHub Action for Generator", | ||
| "description": "CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!", | ||
| "description": null, | ||
| "links": { | ||
| "repoUrl": "https://github.com/asyncapi/cli" | ||
| "repoUrl": "https://github.com/actions-marketplace-validations/asyncapi_github-action-for-generator" | ||
| }, | ||
| "filters": { | ||
| "technology": [ | ||
| "AsyncAPI Generator" | ||
| ], | ||
| "categories": [ | ||
| "github-actions" | ||
| "github-action" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": true | ||
| "isAsyncAPIOwner": false | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Unify GitHub Actions category naming.
This entry uses github-action while other uses github-actions. Standardize on one tag to avoid filtering mismatches.
🤖 Prompt for AI Agents
In config/tools-automated.json around lines 472 to 486, the category tag for
GitHub Actions is set as "github-action" but other entries use "github-actions".
Update this category value to "github-actions" to maintain consistent naming and
avoid filtering mismatches.
| { | ||
| "title": "ZenWave SDK", | ||
| "description": "DDD and API-First for Event-Driven Microservices", | ||
| "links": { | ||
| "websiteUrl": "https://zenwave360.github.io/", | ||
| "docsUrl": "https://zenwave360.github.io/zenwave-sdk/plugins/asyncapi-spring-cloud-streams3/", | ||
| "repoUrl": "https://github.com/zenwave360/zenwave-sdk" | ||
| }, | ||
| "filters": { | ||
| "language": "Java", | ||
| "technology": [ | ||
| "Maven", | ||
| "CLI", | ||
| "Spring Cloud Streams", | ||
| "JHipster JDL" | ||
| ], | ||
| "categories": [ | ||
| "code-generator", | ||
| "dsl", | ||
| "mocking-and-testing", | ||
| "cli" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| } | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Centralize ZenWave SDK metadata under Code Generators.
ZenWave SDK appears in multiple categories. Consider referencing a single definition or shared data block to avoid manual drift.
🤖 Prompt for AI Agents
In config/tools-automated.json between lines 179 and 204, the ZenWave SDK
metadata is duplicated across multiple categories. To fix this, centralize the
ZenWave SDK definition under the "code-generator" category by creating a single
shared data block for its metadata and reference this block wherever needed.
This avoids manual drift and ensures consistency across categories.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit