-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update meetings.json and newsrooom_videos.json #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4139
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe updates remove the first entry for the "Marketing WG Meeting" dated 2025-02-18 from the meetings configuration file. In the newsroom videos configuration, two new video entries are added at the beginning, and two older entries at the end are removed. No code or exported entities are changed. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(0 hunks)config/newsroom_videos.json(1 hunks)
💤 Files with no reviewable changes (1)
- config/meetings.json
⏰ Context from checks skipped due to timeout of 180000ms (2)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/newsroom_videos.json (1)
2-7:Details
✅ Verification successful
Verify video thumbnail & GitHub issue link availability
Please ensure that the newly added video entry for GSoC Welcome Contributors Call | May 29th 2025 is pointing to valid resources. You can run the following script to confirm both the YouTube thumbnail and the GitHub issue URL return a successful HTTP response:
🏁 Script executed:
#!/bin/bash # Verify image thumbnail and issue link for videoId 7O85r0YNdvA urls=( "https://i.ytimg.com/vi/7O85r0YNdvA/hqdefault.jpg" "https://github.com/asyncapi/community/issues/1922" ) for url in "${urls[@]}"; do if ! curl -sSfI "$url" > /dev/null; then echo "❌ Failed to fetch $url" exit 1 fi done echo "✅ All links are reachable for videoId 7O85r0YNdvA"Length of output: 397
✅ Video thumbnail & GitHub issue link are reachable
- https://i.ytimg.com/vi/7O85r0YNdvA/hqdefault.jpg → 200 OK
- asyncapi/community#1922 → 200 OK
No further action required.
| { | ||
| "image_url": "https://i.ytimg.com/vi/zF5aXQ9A6as/hqdefault.jpg", | ||
| "title": "AsyncAPI Design WG Meeting", | ||
| "description": "https://github.com/asyncapi/community/issues/1908.", | ||
| "videoId": "zF5aXQ9A6as" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure title consistency and verify second entry metadata
- The title
"AsyncAPI Design WG Meeting"omits the meeting date, whereas other entries embed dates (e.g., comma-separated like “May 20th 2025”). Consider adding the date to match the existing pattern for better uniformity. - Likewise, please verify that the thumbnail and issue link for videoId zF5aXQ9A6as resolve correctly:
🏁 Script executed:
#!/bin/bash
# Verify image thumbnail and issue link for videoId zF5aXQ9A6as
urls=(
"https://i.ytimg.com/vi/zF5aXQ9A6as/hqdefault.jpg"
"https://github.com/asyncapi/community/issues/1908"
)
for url in "${urls[@]}"; do
if ! curl -sSfI "$url" > /dev/null; then
echo "❌ Failed to fetch $url"
exit 1
fi
done
echo "✅ All links are reachable for videoId zF5aXQ9A6as"Length of output: 397
Add Meeting Date to Title for Consistency
The image thumbnail and issue link for videoId zF5aXQ9A6as have been verified and are reachable.
• In config/newsroom_videos.json (lines 8–13), update the title from
"AsyncAPI Design WG Meeting"to include the meeting date (for example,
"AsyncAPI Design WG Meeting, May 20th 2025") so it matches the date-embedded format used by other entries.
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 8 to 13, update the title field by
appending the meeting date to "AsyncAPI Design WG Meeting" so it matches the
date-embedded format of other entries, for example changing it to "AsyncAPI
Design WG Meeting, May 20th 2025". This ensures consistency in title formatting
across all entries.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores