chore: update tools.json #4072
chore: update tools.json #4072
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
WalkthroughThis update reorganizes the contents of two configuration files: Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4072 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 733 733
Branches 121 121
=========================================
Hits 733 733 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🔭 Outside diff range comments (3)
config/tools-automated.json (3)
53-70:⚠️ Potential issueAlign filter tags with
all-tags.jsonstandards
Thenestjs-asyncapientry uses"Typescript"and"NestJS", which don't match the cases inconfig/all-tags.json("TypeScript"and"Nest Js") and will break tag-based filtering.
Apply this diff:"language": "Typescript", -"language": "Typescript", +"language": "TypeScript", "technology": [ - "Node.js", - "NestJS" + "Node.js", + "Nest Js" ]
180-197:⚠️ Potential issueFix language filter casing for asyncapi-python
Theasyncapi-pythonentry uses"python"(lowercase) butconfig/all-tags.jsondefines"Python". Update as follows:-filters": { - "language": "python", +filters": { + "language": "Python", "technology": [ "amqp" ],
220-243:⚠️ Potential issueAdd missing
CLItag or align technology filters
TheZenWave SDKentry includes"CLI"intechnology, butconfig/all-tags.jsonhas noCLItag. Either:
- Add a
CLIentry inall-tags.json- Replace with an existing tag
Missing tag definitions will prevent proper filtering.
🧹 Nitpick comments (1)
config/tools-automated.json (1)
925-933: Improve filter casing for HTML Template
Thefilters.languagefield uses"javascript"lowercase. To matchall-tags.json, update to"JavaScript". Optionally unify type:-"language": [ - "javascript" -], +"language": "JavaScript",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/all-tags.json(1 hunks)config/tools-automated.json(12 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (9)
config/all-tags.json (1)
1-1: Approve reordering of tags
The updated ordering oflanguagesandtechnologiespreserves all entries, improves logical grouping, and introduces no duplicates or omissions.config/tools-automated.json (8)
94-113: Approve Code-first Zod Sockets metadata
TheZod Socketstool entry has accurate metadata, correct tags (TypeScript,Node.js), and consistent categories.
116-135: Approve Code-first AsyncAPI.Net (ByteBardOrg) metadata
The updatedAsyncAPI.Netentry points to the correct ByteBardOrg repo and retains valid filters.
138-157: Approve Code-first SIO-AsyncAPI metadata
TheSIO-AsyncAPIentry metadata is consistent and aligns with the intended filtering tags.
399-421: Approve DSL category Zod Sockets
The Zod Sockets entry underDSLretains accurate metadata and consistent filter tags.
584-603: Approve Validators AsyncAPI.Net (ByteBardOrg)
The swappedAsyncAPI.Netentry for ByteBardOrg in theValidatorssection has correct links and filters.
606-622: Approve Validators AsyncAPI Validation
TheAsyncAPI Validationentry metadata and tags are correct and consistent.
629-646: Approve Compare tools jasyncapicmp
Thejasyncapicmpentry has proper metadata, tags, and classifications.
649-665: Approve Compare tools AsyncAPI Diff
TheAsyncAPI Diffentry is correctly updated with consistent filter tags and ownership.
| "title": "Node.js Websockets Template", | ||
| "description": "Node.js WebSockets template for the AsyncAPI Generator. It showcases how from a single AsyncAPI document you can generate a server and a client at the same time.", | ||
| "links": { | ||
| "repoUrl": "https://github.com/asyncapi/java-spring-template" | ||
| "repoUrl": "https://github.com/asyncapi/nodejs-ws-template" | ||
| }, | ||
| "filters": { | ||
| "language": [ | ||
| "javascript" | ||
| ], | ||
| "language": "javascript", | ||
| "technology": [ | ||
| "Springboot", | ||
| "Maven", | ||
| "Gradle" | ||
| "Node.js" |
There was a problem hiding this comment.
Standardize language casing for Node.js Websockets Template
The filters.language uses "javascript" (lowercase). For consistency and correct filtering, use "JavaScript":
-"language": "javascript",
+"language": "JavaScript",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "Node.js Websockets Template", | |
| "description": "Node.js WebSockets template for the AsyncAPI Generator. It showcases how from a single AsyncAPI document you can generate a server and a client at the same time.", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/java-spring-template" | |
| "repoUrl": "https://github.com/asyncapi/nodejs-ws-template" | |
| }, | |
| "filters": { | |
| "language": [ | |
| "javascript" | |
| ], | |
| "language": "javascript", | |
| "technology": [ | |
| "Springboot", | |
| "Maven", | |
| "Gradle" | |
| "Node.js" | |
| "title": "Node.js Websockets Template", | |
| "description": "Node.js WebSockets template for the AsyncAPI Generator. It showcases how from a single AsyncAPI document you can generate a server and a client at the same time.", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/nodejs-ws-template" | |
| }, | |
| "filters": { | |
| - "language": "javascript", | |
| + "language": "JavaScript", | |
| "technology": [ | |
| "Node.js" |
| "title": "Java Spring Cloud Stream Template", | ||
| "description": "Java Spring Cloud Stream template for the AsyncAPI Generator", | ||
| "links": { | ||
| "repoUrl": "https://github.com/asyncapi/html-template" | ||
| "repoUrl": "https://github.com/asyncapi/java-spring-cloud-stream-template" | ||
| }, | ||
| "filters": { | ||
| "language": "javascript", | ||
| "language": [ | ||
| "javascript" | ||
| ], |
There was a problem hiding this comment.
Unify filter structure and casing for Java Spring Cloud Stream Template
This entry’s filters.language field is an array of "javascript" (lowercase), which is inconsistent with other entries and tag definitions ("JavaScript"). Decide on a single type (string vs array) and correct casing:
-"language": [
- "javascript"
-],
+"language": ["JavaScript"],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "Java Spring Cloud Stream Template", | |
| "description": "Java Spring Cloud Stream template for the AsyncAPI Generator", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/html-template" | |
| "repoUrl": "https://github.com/asyncapi/java-spring-cloud-stream-template" | |
| }, | |
| "filters": { | |
| "language": "javascript", | |
| "language": [ | |
| "javascript" | |
| ], | |
| "title": "Java Spring Cloud Stream Template", | |
| "description": "Java Spring Cloud Stream template for the AsyncAPI Generator", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/java-spring-cloud-stream-template" | |
| }, | |
| "filters": { | |
| "language": ["JavaScript"], |
| "title": "Java Spring Template", | ||
| "description": "Java Spring template for the AsyncAPI Generator", | ||
| "links": { | ||
| "repoUrl": "https://github.com/asyncapi/java-spring-cloud-stream-template" | ||
| "repoUrl": "https://github.com/asyncapi/java-spring-template" | ||
| }, | ||
| "filters": { | ||
| "language": [ | ||
| "javascript" | ||
| ], |
There was a problem hiding this comment.
Unify filter structure and casing for Java Spring Template
The filters.language uses ["javascript"]. It should either be a string or match the case in all-tags.json ("JavaScript"). Apply:
-"language": [
- "javascript"
-],
+"language": "JavaScript",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "Java Spring Template", | |
| "description": "Java Spring template for the AsyncAPI Generator", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/java-spring-cloud-stream-template" | |
| "repoUrl": "https://github.com/asyncapi/java-spring-template" | |
| }, | |
| "filters": { | |
| "language": [ | |
| "javascript" | |
| ], | |
| "filters": { | |
| - "language": [ | |
| - "javascript" | |
| - ], | |
| + "language": "JavaScript", |
| "title": "Java Template", | ||
| "description": "Java template for the AsyncAPI Generator", | ||
| "links": { | ||
| "repoUrl": "https://github.com/asyncapi/nodejs-ws-template" | ||
| "repoUrl": "https://github.com/asyncapi/java-template" | ||
| }, | ||
| "filters": { | ||
| "language": "javascript", | ||
| "language": [ | ||
| "javascript" | ||
| ], |
There was a problem hiding this comment.
Correct language filter for Java Template
The Java Template mistakenly sets "javascript" under filters.language. It should be "Java" to match the template’s language:
-"language": [
- "javascript"
-],
+"language": "Java",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "Java Template", | |
| "description": "Java template for the AsyncAPI Generator", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/nodejs-ws-template" | |
| "repoUrl": "https://github.com/asyncapi/java-template" | |
| }, | |
| "filters": { | |
| "language": "javascript", | |
| "language": [ | |
| "javascript" | |
| ], | |
| "title": "Java Template", | |
| "description": "Java template for the AsyncAPI Generator", | |
| "links": { | |
| "repoUrl": "https://github.com/asyncapi/java-template" | |
| }, | |
| "filters": { | |
| - "language": [ | |
| - "javascript" | |
| - ], | |
| + "language": "Java", |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit