-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update tools.json #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tools.json #4040
Conversation
WalkthroughThis pull request updates two configuration files. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4040 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
config/tools-automated.json (1)
1563-1602: 💡 Verification agent❓ Verification inconclusive
Potential Language Field Mismatch in Generator Templates
Several entries in the “AsyncAPI Generator Templates” section—such as “Java Spring Cloud Stream Template”, “Java Template”, and “Java Spring Template” (lines 1563–1602 and 1660–1680)—have their filter for “language” set to["javascript"]even though their titles and descriptions imply a Java-based template. Please verify that the language classification accurately reflects the intended technology for these templates.Also applies to: 1660-1680
Action Required: Correct Language Filter in Java Template Configurations
The generator configurations for Java-based templates are presently set with a"language"filter of["javascript"], resulting in a clear mismatch given the template titles and descriptions. Please verify that these entries (specifically in config/tools-automated.json on lines 1563–1602 for "Java Spring Cloud Stream Template" and "Java Template", as well as similar entries on lines 1660–1680) are intended for Java. If they are, update the"language"field to["java"]to accurately reflect the underlying technology.
🧹 Nitpick comments (5)
config/tools-automated.json (3)
6-25: Duplicate “SIO-AsyncAPI” Entries Detected
Both entries for “SIO-AsyncAPI” (lines 6–25 and 27–48) share identical titles, descriptions, links, and filter settings. Please verify if having two identical entries is intentional for display or categorization purposes; if not, consider consolidating them.Also applies to: 27-48
49-68: Duplicate “AsyncAPI Server API” Entries Detected
The “AsyncAPI Server API” tool appears twice (lines 49–68 and 70–88) reverting to the original title and description. Kindly confirm that both entries are required for your use case, or if one should be removed to avoid redundancy.Also applies to: 70-88
889-956: Inconsistent GitHub Actions Entries
Within the GitHub Actions section (lines 889–956), multiple entries for “GitHub Action for Generator” are present—with one set having a null description and another offering an extended description and slightly different filter categories (e.g. “github-action” vs. “github-actions”). Please verify the intended naming and categorization to ensure consistency.config/all-tags.json (2)
1-1: Duplicate Entries Check
There appear to be multiple entries for the same technology (e.g., "Socket.IO", "TypeScript", "AsyncAPI Generator", and others). Please verify if these duplicates are intentional for supporting different use cases or if they can be consolidated to reduce redundancy.
1-1: Trailing Newline Missing
It is best practice to include a trailing newline at the end of the file. Adding one can prevent potential diff issues and ensure compatibility with various tools.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/all-tags.json(1 hunks)config/tools-automated.json(23 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (6)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - macos-13
🔇 Additional comments (6)
config/tools-automated.json (5)
95-115: Updated “Zod Sockets” Entry in Code-first Tools
The “Zod Sockets” tool entry (lines 95–115) now includes an updated description, revised links, and adjusted filtering (language set to Python, technologies to [“Socket.IO”, “Flask”], and categories updated to include “code-first”). These changes look consistent with the intended rebranding; please confirm that they align with your overall categorization strategy.
366-394: Duplicate “Golang AsyncAPI Code Generator” Entries
There are two almost identical entries for “Golang AsyncAPI Code Generator” (lines 366–394). Verify whether the duplication is intentional or if these entries should be merged.
433-474: Duplicate “AsyncAPI Modelina” Entries
The tool “AsyncAPI Modelina” appears twice with identical details (lines 433–474). Please check if this redundancy is by design or if consolidation is preferred.
1740-1756: Language Classification for HTML Template
The “HTML Template” entry (lines 1740–1756) currently lists its language as["javascript"]while its technology filter includes “HTML.” Confirm whether the language should be updated to “HTML” or if the current setting is intentional (for example, if the generator is implemented in JavaScript).
1-1798: Overall Structure & Duplication Review
This configuration file has been extensively updated across various categories and tool sections. There are multiple duplicate or near-duplicate tool entries (e.g., in the APIs, Code Generator Templates, and GitHub Actions sections). Please review these duplications to ensure they are intentional and align with your design goals.config/all-tags.json (1)
1-1: Uniform Color Update and JSON Structure Integrity
The file’s JSON structure is intact, and the update applies a uniform color palette ("bg-[#61d0f2]" for backgrounds and "border-[#40ccf7]" for borders) across many entries. Please confirm that this unification aligns with the current design guidelines and branding strategies.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
Style
New Features