chore: update tools.json #3993
chore: update tools.json #3993
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
WalkthroughThis pull request makes cosmetic and configuration updates. In the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3993 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (5)
config/tools-automated.json (5)
1413-1431:⚠️ Potential issueDuplicate “Java Template” Entry
A duplicate Java Template appears with the same inconsistency in the language array.
• Action: In addition to deduplication, please address the language mismatch as noted above.
1433-1453:⚠️ Potential issue“Java Spring Template” Entry – Language Field Check
This block for"Java Spring Template"again lists the"language"as an array with"javascript", yet the description indicates it is a Java Spring template.
• Recommendation: Revisit the language filter (perhaps it should be"Java"or include both if hybrid) to avoid confusion.
1606-1625:⚠️ Potential issueDuplicate “Java Spring Cloud Stream Template” Entry
The duplicate of the previous entry carries the same language field concern.
• Action: Address duplication and update the language specification as needed.
1585-1604: 💡 Verification agent❓ Verification inconclusive
First “Java Spring Cloud Stream Template” Entry
This entry uses"language": ["javascript"], yet it is a Java Spring Cloud Stream template.
• Critical Issue: The language filter is likely misconfigured. Please verify if the language should be"Java"(or a different appropriate value) rather than"javascript".
Critical: Update Language Filter for Java Template
The "Java Spring Cloud Stream Template" entry in
config/tools-automated.jsonincorrectly specifies"language": ["javascript"]. Given that the title, description, and repository URL indicate this is a Java-based template, please update the language filter to"Java"(or the appropriate Java identifier) to ensure consistency.
- File:
config/tools-automated.json- Lines: 1585-1604
- Action: Change
"language": ["javascript"]to"language": ["Java"]
1393-1411: 💡 Verification agent❓ Verification inconclusive
First “Java Template” Entry
This tool now titled"Java Template"includes a repo URL for the Java template but its filter for"language"is provided as an array with"javascript".
• Critical Issue: The mismatch between the template name (Java) and the language filter ("javascript") is concerning. Please verify and update the language field to reflect the correct technology (e.g."Java") if this is an error.
Critical: Mismatch in Language Filter for “Java Template”
In fileconfig/tools-automated.json(lines 1393-1411), the tool titled "Java Template" incorrectly lists"javascript"under itslanguagefilter. Given that the template is for Java (as also indicated by the"technology": ["Java"]filter and the repository URL), please update thelanguagefield to"Java"(or an appropriate Java-related identifier) to maintain consistency.
• File:config/tools-automated.json
• Issue Location: Lines 1393-1411
• Required Change: Update"language": ["javascript"]to"language": ["Java"]
🧹 Nitpick comments (15)
config/all-tags.json (1)
1-75: Standardizing Color Codes & Duplicate Check
The entire JSON has been replaced to standardize the color codes for both languages and technologies. The new values (for example, changing the TypeScript entry to usebg-[#61d0f2]andborder-[#40ccf7]) are applied uniformly.
• Action: Verify that these new color codes align with the brand/design guidelines.
• Note: There appear to be duplicate entries for some items (e.g. multiple "TypeScript" entries or repeated updates for other technologies). Confirm that duplicates are intentional rather than accidental.config/tools-automated.json (14)
117-134: New “nestjs-asyncapi” Entry – Language Capitalization
A new tool entry with title"nestjs-asyncapi"has been added. The description, repository link, and filter settings (with technology values"Node.js"and"NestJS") look correct.
• Suggestion: The filter field"language": "Typescript"uses a different capitalization than the more common"TypeScript". Consider standardizing this while comparing with other entries.
270-287: First “asyncapi-python” Entry – Language Consistency
The tool"asyncapi-python"now points to a GitHub repo and PyPI link, with filters using"language": "python"and technology["amqp"].
• Recommendation: For consistency with other language entries (e.g. “Python” elsewhere), consider capitalizing to"Python".
289-306: Duplicate “asyncapi-python” Entry
A subsequent block repeats the"asyncapi-python"entry with identical details.
• Action: Confirm if the duplicate is intentional (for example, if the tool is meant to appear in two lists) or if one should be removed to avoid redundancy.
308-321: First “Golang AsyncAPI Code Generator” Entry
This entry for the Go code generator is updated with its repo URL and filters using"language": "golang".
• Suggestion: Consider whether you want to standardize the language naming—for example, using"Go"or"Golang"consistently across the configuration.
322-336: Duplicate “Golang AsyncAPI Code Generator” Entry
A second, identical block for the Go code generator appears immediately after.
• Action: Verify that duplicating this entry is intentional.
697-712: Duplicate “Glee” Entry
A duplicate of the"Glee"tool is present with identical settings.
• Action: Ensure that multiple entries for “Glee” are intended. If not, consider deduplicating.
737-757: Duplicate “Zod Sockets” Entry
A second block replicates the"Zod Sockets"tool with identical attributes.
• Action: Confirm that this duplicate is required for the document’s organization.
1039-1057: Duplicate “jasyncapicmp” Entry
A nearly identical duplicate follows.
• Action: Reevaluate whether both entries are necessary.
1157-1174: Duplicate “AsyncAPI CLI” Block with Fork Link
Another block duplicates the CLI entry with the same fork details.
• Action: Check if the repeated CLI entries are needed or if consolidation is possible.
1202-1226: Duplicate “ZenWave SDK” Entry in CLIs
A duplicate entry for"ZenWave SDK"follows immediately.
• Action: Verify if both entries should exist. If not, consider removing the duplicate.
1477-1493: First “HTML Template” Entry
The"HTML Template"entry is updated with its repo URL and proper filters.
• Observation: The language still appears as"javascript"while the technology is"HTML". Confirm that this is the intended classification.
1495-1511: Duplicate “HTML Template” Entry
A second block for the HTML Template repeats the earlier entry.
• Action: If duplicates are not desired, consider removing one instance.
1531-1547: Duplicate “Node.js Multiprotocol Template” Entry
A near duplicate follows immediately; please confirm whether this redundancy is required.
1567-1583: Duplicate “Node.js Websockets Template” Entry
A duplicate block of the Websockets Template appears; double-check duplication intent.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/all-tags.json(1 hunks)config/tools-automated.json(23 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (8)
config/tools-automated.json (8)
136-156: Reinstated “AsyncAPI.Net” Entry
This block reinstates the"AsyncAPI.Net"tool with its .NET details. The URLs and filters (with language"C#") are properly specified.
• Action: Double-check that this reinstatement fits the overall strategy and that there is no conflict with the new entries.
681-696: First “Glee” Entry (Frameworks Section)
The tool"Glee"now appears with its repo URL and a filter listing"technology": ["TypeScript"]. The property"isAsyncAPIOwner": trueis set.
• Note: As there is no explicit language field here, confirm that this lack is acceptable for frameworks.
715-735: First “Zod Sockets” Entry (Frameworks Section)
This block for"Zod Sockets"updates the links and filters. The"language": "TypeScript"setting is used and the technology array includes both"Node.js"and"TypeScript".
• Observation: The values look correct; please verify that the inclusion of both Node.js and TypeScript in technology is deliberate.
1019-1037: First “jasyncapicmp” (Compare tools Section)
For the tool now titled"jasyncapicmp", the description, links, and filter using"language": "Java"with technology["Maven"]look correct.
• Note: The property"isAsyncAPIOwner": falseis explicitly set; ensure this is accurate.
1138-1155: First “AsyncAPI CLI” Entry – Fork Update
The entry for"AsyncAPI CLI"now points to a fork at"https://github.com/hkirat/asyncapi-fork". The description remains unchanged.
• Question: Is this fork meant to replace the original? Confirm that the fork’s repository is the intended target for users.
1176-1200: First “ZenWave SDK” in CLIs Section
The"ZenWave SDK"entry appears here with updated links and filters (language"Java"and technology including"Maven","CLI","Spring Cloud Streams", and"JHipster JDL").
• Observation: If this SDK is being reclassified under CLIs, ensure that this move is coordinated with related documentation.
1513-1529: First “Node.js Multiprotocol Template” Entry
This entry for the Node.js Multiprotocol Template appears correct with"language": "javascript"and technology"Node.js".
1549-1565: First “Node.js Websockets Template” Entry
The Websockets Template entry looks well formed with"language": "javascript"and appropriate technology.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
Style
New Features