-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update meetings.json and newsrooom_videos.json #3984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3984
Conversation
WalkthroughThe update modifies the meetings schedule in the configuration file by removing a "Marketing WG Meeting" entry scheduled for December 17, 2024, and adding a new entry for April 1, 2025. Both entries share similar fields (title, calendar link, URL, banner, and date) and the new entry is inserted before the last existing entry in the JSON array. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3984 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/meetings.json (1)
85-92: New Marketing WG Meeting Entry ValidatedThe new "Marketing WG Meeting" entry has been added with the required fields (
title,calLink,url,banner, anddate). The values appear consistent with the schema used by the other meeting entries. Please verify the following:
- Insertion Position & Order: Confirm that inserting this entry at this position (just before the closing bracket) matches the intended order. If you expect the meetings to be arranged chronologically, you might want to consider sorting them or double-checking the order.
- Removal Consistency: The PR objectives mention removing a "Marketing WG Meeting" scheduled for December 17, 2024. Although that entry isn’t shown here, ensure that its removal is complete and that no stale data remains elsewhere.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/meetings.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (2)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
|
/rtm |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit