fix : draft for checking failing Lighthouse CI #3921
Conversation
Related to #3648 Update the Lighthouse CI workflow to use the latest versions of actions and configurations. * **Lighthouse CI Action**: Update the `uses` directive to `treosh/lighthouse-ci-action@v12`. * **Lighthouse Score Report**: Update the `uses` directive to `actions/github-script@v7`. * **LightHouse Statistic Comment**: Update the `uses` directive to `marocchino/sticky-pull-request-comment@v3.0`. * **Lighthouse Configuration**: Add `categories:performance` with a minimum score of 0.9 to the `ci.assert.assertions` object. Include `uses-http2` in the `ci.collect.settings.skipAudits` array.
Recxsmacx
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve and
derberg
as code owners
WalkthroughThis pull request updates the versions of several GitHub Actions used in the Lighthouse CI workflow and adjusts the Lighthouse configuration. The GitHub Actions in Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as GitHub Runner
participant Audit as Lighthouse Audit (v12)
participant Score as Score Report (v7)
participant Comment as Stat Comment (v3.0)
Runner->>Audit: Trigger Lighthouse Audit
Audit-->>Runner: Return audit results
Runner->>Score: Process score report
Score-->>Runner: Return score data
Runner->>Comment: Update PR comment
Comment-->>Runner: Confirm comment update
Suggested labels
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
We require all PRs to follow Conventional Commits specification. |
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3921 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/lighthouserc.json (1)
7-8: Add SEO and Performance Assertions
The configuration now enforces SEO and performance metrics via new assertions:
"categories:seo": ["error", {"minScore": 1.00}]"categories:performance": ["error", {"minScore": 0.90}]A perfect score of 1.00 for SEO is very strict; please confirm this is intentional given the nature of the SEO audits and the variability of web content. Likewise, the performance threshold of 0.90 should be tested to ensure it aligns with realistic performance criteria for your project.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/lighthouse-ci.yml(3 hunks).github/workflows/lighthouserc.json(2 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (4)
.github/workflows/lighthouse-ci.yml (3)
51-57: Update Lighthouse Audit Action to v12
The new version (v12) oftreosh/lighthouse-ci-actionis now in use. Please verify that the new version’s output structure (artifacts, reports, etc.) remains compatible with the downstream steps—especially the configuration file at./.github/workflows/lighthouserc.json—and does not introduce unexpected side effects.
64-70: Upgrade GitHub Script Action to v7
The action for the Lighthouse Score Report now usesactions/github-script@v7. Ensure that any changes in how the script handles outputs or environment variables are fully compatible with your existing scoring logic. It’s a good idea to test the full workflow end-to-end after this update.🧰 Tools
🪛 actionlint (1.7.4)
67-67: property "manifest" is not defined in object type {assertionresults: string; links: string; resultspath: string}
(expression)
88-96: Update Sticky PR Comment Action to v3.0
The Lighthouse Statistic Comment step now usesmarocchino/sticky-pull-request-comment@v3.0. Please double-check that the token parameter (GH_TOKENprovided here) is intentional and that it conforms with the new version's requirements (many actions expect the token underGITHUB_TOKEN). Verifying the action’s documentation for any input changes would be beneficial..github/workflows/lighthouserc.json (1)
19-20: Update Skipped Audits Settings
TheskipAuditsarray now includes"offline-start-url"and"uses-http2". Before proceeding, verify that skipping these audits is acceptable for your overall Lighthouse evaluation, as these audits are sometimes crucial for identifying issues related to offline behavior and HTTP/2 usage.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/lighthouserc.json (1)
11-21: Updated Skipped Audits in Collection Settings:
The"skipAudits"array now includes"uses-http2". Confirm that excluding this audit does not bypass important checks that could impact the overall analysis of your site’s HTTP/2 performance.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/lighthouse-ci.yml(2 hunks).github/workflows/lighthouserc.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/lighthouse-ci.yml
🔇 Additional comments (1)
.github/workflows/lighthouserc.json (1)
2-10: Lighthouse Assertions Updated:
The assertions for accessibility, best-practices, and SEO have been adjusted to use new minimum score thresholds (0.95, 0.90, 0.95 respectively) while also introducing a new performance assertion with a minimum score of 0.85. Please verify that these thresholds are consistent with your quality standards and intended performance objectives.
* Update `uses` directive for `Lighthouse Audit` step to use `treosh/lighthouse-ci-action@v12` * Update `uses` directive for `Lighthouse Score Report` step to use `actions/github-script@v7` * Update `uses` directive for `LightHouse Statistic Comment` step to use `marocchino/sticky-pull-request-comment@v3.0` * Add `artifactName` to `Lighthouse Audit` step with value `lighthouse_results` * Fix spacing issue in `PR_NUMBER` environment variable
|
#3842 is an bounty issue and it's assigned to @sambhavgupta0705 |
|
@vishvamsinh28 got it ! |
3 participants
Related to #3648
Update the Lighthouse CI workflow to use the latest versions of actions and configurations.
usesdirective totreosh/lighthouse-ci-action@v12.usesdirective toactions/github-script@v7.usesdirective tomarocchino/sticky-pull-request-comment@v3.0.categories:performancewith a minimum score of 0.9 to theci.assert.assertionsobject. Includeuses-http2in theci.collect.settings.skipAuditsarray.Summary by CodeRabbit
New Features
Chores