-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add Munich CfP banner #3879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates the banner configuration for a campaign. The modifications include updating the event location to Munich, Germany, revising the event dates and venue details, and adjusting the call-for-papers deadline. These updates alter specific properties within the banner object without changing any exported or public entity declarations. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3879 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/campaigns/banners.ts (1)
21-22: Updated City & Date Location PropertiesThe
cityproperty is updated to"Munich Edition"and thedateLocationproperty now reflects the new event details ("2nd - 3rd of July, 2025 | München, Germany"). Please verify that the mixture of English ("Munich") and German ("München") in these values is intentional for your audience.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/campaigns/banners.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
components/campaigns/banners.ts (1)
25-25: CFP Deadline UpdateThe
cfpDeadlineproperty has been updated to"2025-05-11T06:00:00Z", which aligns with the PR objectives. Confirm that this new deadline integrates correctly with any date-based logic (such as inshouldShowBanner) elsewhere in the code base.
sambhavgupta0705
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc: @AceTheCreator @akshatnema
|
/rtm |
|
Hello, @akshatnema! 👋🏼 |
|
/rtm |
Call for Speakers Banner for Munich Conf
Summary by CodeRabbit