fix: all test cases not passing for commit on external repository #3838
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| # Centrally managed in asyncapi/.github repo | ||
| name: Lint PR title | ||
|
|
||
| on: | ||
|
|
@@ -12,35 +10,32 @@ jobs: | |
| name: Lint PR title | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - if: > | ||
| !contains(fromJson('["asyncapi-bot", "dependabot[bot]", "dependabot-preview[bot]", "allcontributors[bot]"]'), github.actor) | ||
| uses: amannn/action-semantic-pull-request@v5.2.0 | ||
| id: lint_pr_title | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GH_TOKEN}} | ||
| with: | ||
| subjectPattern: ^(?![A-Z]).+$ | ||
| subjectPatternError: | | ||
| The subject "{subject}" in the PR title "{title}" should start with a lowercase letter. | ||
|
|
||
| - if: ${{ always() && steps.lint_pr_title.outputs.error_message != null }} | ||
| name: Comment on PR | ||
| uses: marocchino/sticky-pull-request-comment@v2.5.0 | ||
| with: | ||
| header: pr-title-lint-error | ||
| GITHUB_TOKEN: ${{ secrets.GH_TOKEN}} | ||
| message: | | ||
| We require all PRs to follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/). | ||
| ``` | ||
| ${{ steps.lint_pr_title.outputs.error_message }} | ||
| ``` | ||
|
|
||
| - if: ${{ steps.lint_pr_title.outputs.error_message == null }} | ||
| name: Delete PR title lint comment | ||
| uses: marocchino/sticky-pull-request-comment@v2.5.0 | ||
| with: | ||
| header: pr-title-lint-error | ||
| delete: true | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ const CommunityEvents = () => { | |
| </div> | ||
| <div className='mt-10'> | ||
| {!events || events.length === 0 ? ( | ||
| <div className='flex place-content-center'> | ||
| <Paragraph typeStyle={ParagraphTypeStyle.md} className='mx-auto mt-5 max-w-2xl'> | ||
| No Events. Check back later! | ||
| </Paragraph> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,7 +85,7 @@ export default function MobileNavMenu({ | |
| <div className='space-y-2 px-5 py-2' onClick={() => showMenu('learning')} data-testid='MobileNav-docs'> | ||
| <h4 className='flex justify-between font-medium text-gray-800'> | ||
| {' '} | ||
| <Link href='/docs' className='flex cursor-pointer'> | ||
| Docs | ||
| </Link> | ||
| <NavItemDropdown /> | ||
|
|
@@ -95,7 +95,7 @@ export default function MobileNavMenu({ | |
| <div className='space-y-2 px-5 py-2' onClick={() => showMenu('tooling')} data-testid='MobileNav-tools'> | ||
| <h4 className='flex justify-between font-medium text-gray-800'> | ||
| {' '} | ||
| <Link href='/tools' className='flex cursor-pointer'> | ||
| Tools | ||
| </Link> | ||
| <NavItemDropdown /> | ||
|
|
@@ -104,7 +104,7 @@ export default function MobileNavMenu({ | |
| </div> | ||
| <div className='space-y-2 px-5 py-2' onClick={() => showMenu('community')} data-testid='MobileNav-community'> | ||
| <h4 className='flex justify-between font-medium text-gray-800'> | ||
| <Link href='/community' className='flex cursor-pointer'> | ||
| Community | ||
| </Link> | ||
| <NavItemDropdown /> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Setting Environment Variable for 'shouldrun'.
Using
$GITHUB_ENVto setshouldrunis consistent with our updated practices. Please check and remove any trailing spaces that might be present after this command to satisfy YAML linting requirements.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 22-22: trailing spaces
(trailing-spaces)