fix: fix bug in buttons redirecting to the same page #3808
Conversation
Fixes #3799 Update the URL values in the JSON file to ensure they are correct. * **APIs Section** - Update the `websiteUrl`, `docsUrl`, and `repoUrl` for the "SIO-AsyncAPI" tool. * **Code-first tools Section** - Update the `websiteUrl`, `docsUrl`, and `repoUrl` for the "SIO-AsyncAPI" tool.
Recxsmacx
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve and
derberg
as code owners
WalkthroughThis pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3808 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/tools-automated.json (2)
408-424: New GitHub Action for Generator Entry (First Instance).
This entry adds a GitHub Action with the title "GitHub Action for Generator" but with a null description. If the null value is intentional because no description is available yet, please consider adding a brief description to clarify its functionality. Otherwise, update it accordingly.
426-441: Duplicate Title in GitHub Actions: Generator.
A second entry also uses the title "GitHub Action for Generator" yet provides a detailed description and different attributes (including a distinct repository URL and ownership flag). If these represent two separate tools, it may be confusing to have identical titles. Consider differentiating them (for example, by appending a distinguishing suffix) to avoid ambiguity for end users.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/tools-automated.json(15 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (4)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
🔇 Additional comments (18)
config/tools-automated.json (18)
6-11: Updated Tool Title and URLs in APIs Section.
The tool’s title has been changed to "AsyncAPI Server API" and its URLs (website, docs, and repo) have been updated to new endpoints. Please verify that these endpoints correctly reflect the intended server API and that they are operational.
25-32: Revised SIO-AsyncAPI Entry in APIs Section.
The SIO-AsyncAPI tool now uses updated link values and has a refined description. In addition, the ownership flag (isAsyncAPIOwner) has been adjusted. Please confirm that the new URLs (websiteUrl, docsUrl, and repoUrl) correctly point to the intended pages and that the ownership status now accurately reflects the tool’s actual affiliation.
75-81: Consistent Update for SIO-AsyncAPI in Code-first Tools.
This entry mirrors the changes applied in the APIs section with the same updated URLs and description for the SIO-AsyncAPI tool. Ensure that the updates are consistent across both sections.
143-160: Addition of New Tool: asyncapi-python.
A new tool, "asyncapi-python", has been introduced with links to its repository and PyPI page. The filters indicate it is a Python-based code generator for type-safe asynchronous applications. This addition meets the new feature goals—please verify that the links are correct and that the filter attributes (language, technology, categories, etc.) accurately describe the tool.
365-380: Swapped and Updated Framework Entry: Glee.
The tool formerly known under a different branding (likely “Zod Sockets”) has been updated to "Glee" with a new description and repository URL. The ownership flag has been set to true. Ensure that this swap is intentional and that related documentation (if any) is updated to reflect the new identity.
382-401: Reconfigured Framework Entry: Zod Sockets.
The "Zod Sockets" entry now features revised links, language, technology, and category settings. Notably, the technology list and ownership flag have been updated. Please double-check that these changes correctly represent the tool’s current state after the swap with Glee.
443-458: Updated GitHub Action for CLI.
The "GitHub Action for CLI" entry now includes updated links and filter attributes. The changes appear to correctly differentiate this tool from the generator entries. No further issues were noted here.
516-532: Revised Validators Entry: AsyncAPI Validation.
The "AsyncAPI Validation" tool now has an updated description and repository URL along with revised filter attributes. The modifications appear consistent with its intended functionality as a message validation package.
533-554: Reconfigured Validators Entry: AsyncAPI.Net.
This tool now appears with an updated description and URL details, and its filter attributes have been adjusted (including language and technology). Ensure that these changes correctly reflect its role as a .NET validation utility.
561-579: Updated Compare Tools Entry: jasyncapicmp.
The tool "jasyncapicmp" now shows updated website, docs, and repo URLs and filter information. Please verify that these endpoints are correct and that its categorization (including language and technology) is accurate.
580-597: Modified Compare Tools Entry: AsyncAPI Diff.
The "AsyncAPI Diff" tool has been updated with revised repository URLs and filter attributes. The ownership flag now reflects the intended status. Confirm that these changes align with the intended functionality and grouping of compare-tool entries.
677-695: Updated IDE Extension: jAsyncAPI - IDEA Plugin.
The "jAsyncAPI - IDEA plugin" entry now includes updated links (pointing to the JetBrains marketplace and GitHub repository) and filter values. These changes appear to improve the accuracy of how the tool is presented. Please verify that the updated URLs and labels (e.g. language "Kotlin") are correct.
697-714: Refined IDE Extension: asyncapi-preview.
The "asyncapi-preview" tool now features an updated repository URL and filter adjustments for technology tags. The changes ensure that the entry accurately describes the VSCode extension’s functionality.
721-737: Updated AsyncAPI Generator Template: HTML Template.
The "HTML Template" entry now provides an updated repository URL and filter settings. The changes are aligned with its purpose of generating static documentation using the AsyncAPI React component.
738-755: Refined Template: Node.js Multiprotocol Template.
The "Node.js Multiprotocol Template" has been updated with corrected repository references and maintains the appropriate filter attributes. The entry now clearly specifies its capability to generate a server supporting multiple protocols.
757-775: Updated Template: Java Spring Cloud Stream Template.
This template entry now shows an updated repo URL and revised filter attributes. One point to verify: the language is specified as "javascript" (within an array) despite the template being for a Java Spring Cloud Stream service. Please confirm that this designation is intentional (perhaps reflecting the template’s implementation language rather than its output).
777-794: Revised Template: Node.js Websockets Template.
The "Node.js Websockets Template" now reflects updated repository information and filter details. The changes appear correct and consistent with the template’s purpose.
816-836: Updated Template: Java Spring Template.
The "Java Spring Template" entry now includes updated titles, repository URL, and filter values. Similar to the previous Java Spring Cloud Stream Template, the language filter is set as ["javascript"]. Please verify that this is intentional (e.g., if the template is implemented in JavaScript despite generating Java/Spring code).
|
Why are there a lot of changes? The issue that was reported was about one such tool only? Also, where are you getting the new data? Manually scraping or AI? |
|
@anshgoyalevil I think spending some extra time to the website is automatically helping me to find such issues , btw I'm searching the tools name and the link is there so no need of any AI is required and I'm constantly discussing my doubts on the slack so they're helping me too |
|
not required |
3 participants
Fixes #3799
Update the URL values in the JSON file to ensure they are correct.
APIs Section
websiteUrl,docsUrl, andrepoUrlfor the "SIO-AsyncAPI" tool.Code-first tools Section
websiteUrl,docsUrl, andrepoUrlfor the "SIO-AsyncAPI" tool.Summary by CodeRabbit
New Features
Refactor
Revert