feat: add tests for build tools script #3245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishvamsinh28
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
magicmatatjahu
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3245--asyncapi-website.netlify.app/ |
sambhavgupta0705
added
the
gsoc
Contributor
Author
|
@anshgoyalevil Sorry, I forgot to add that file! 😅 Yes, there is a need for it. When we test the combineTools function, we will have to pass the path as an argument to test it in a temporary directory to avoid making changes to the actual files. Since we are using that function only in this file, I thought it would be a good idea to make the change in this PR. |
| resolve(__dirname, '../../config', 'all-tags.json'), | ||
| JSON.stringify({ languages: languageList, technologies: technologyList }), | ||
| ) | ||
| fs.writeFileSync(toolsPath,JSON.stringify(finalTools)); |
Member
There was a problem hiding this comment.
What does final tools signify??
Contributor
Author
|
@anshgoyalevil updated test |
asyncapi-bot
requested review from
BhaswatiRoy,
J0SAL,
TRohit20 and
VaishnaviNandakumar
Contributor
Author
|
@anshgoyalevil test updated |
anshgoyalevil
approved these changes
Oct 3, 2024
Member
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test for build-tools.js script