docs: add URL variables in AsyncAPI Document #1890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kakabisht
requested review from
asyncapi-bot-eve and
quetzalliwrites
as code owners
Contributor
Author
|
Hi, could you assign this to me? @alequetzalli |
Closed
fmvilas
requested changes
Aug 31, 2023
quetzalliwrites
added
📑 docs
area/docs
quetzalliwrites
suggested changes
Sep 1, 2023
Contributor
quetzalliwrites
left a comment
quetzalliwrites
left a comment
There was a problem hiding this comment.
great first draft, still work left to do and feedback to address ✌🏽
btw, the first thing we want to do moving forward is remember to review your work in the preview links... you should be doing this in each PR, this is why you missed several of these mistakes 😄✌🏽
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
fmvilas
requested changes
Sep 28, 2023
TRohit20
reviewed
Nov 8, 2023
Collaborator
TRohit20
left a comment
TRohit20
left a comment
There was a problem hiding this comment.
Links are technically accurate but suggested a better relative path that works just as good and suggested by Lukasz on my PRs.
fmvilas
requested changes
Nov 23, 2023
Comment on lines
+14
to
+29
| The diagram below describes how to use variable urls in AsyncAPI. | ||
|
|
||
| ```mermaid | ||
| graph TD | ||
|
|
||
| A[AsyncAPI Server] | ||
| B[Components] | ||
| C[Server URL] | ||
|
|
||
| style A fill:#47BCEE,stroke:#47BCEE; | ||
| style B fill:#47BCEE,stroke:#47BCEE; | ||
| style C fill:#47BCEE,stroke:#47BCEE; | ||
|
|
||
| B -->|Defines serverVariables| C | ||
| C -->|Reusable variables| A | ||
| ``` |
Member
There was a problem hiding this comment.
I honestly don't think a diagram is helping here. I'd completely remove it.
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
thulieblack
moved this from Community PR under Review 🧐
to Done 🚀
in AsyncAPI Docs Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description : Add Variables in URL
Refer: #1509