docs: add complex payload schema in AsyncAPI Document #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
quetzalliwrites
added
📑 docs
area/docs
kakabisht
requested review from
asyncapi-bot-eve and
quetzalliwrites
as code owners
Closed
fmvilas
requested changes
Aug 31, 2023
Member
fmvilas
left a comment
fmvilas
left a comment
There was a problem hiding this comment.
Left some comments. Overall, I think we shouldn't recommend Avro over JSON Schema, especially because the default format in AsyncAPI is JSON Schema.
Also, why is this a concept page? Feels weird to me tbh. Looks more like a guide.
quetzalliwrites
suggested changes
Sep 1, 2023
Contributor
quetzalliwrites
left a comment
quetzalliwrites
left a comment
There was a problem hiding this comment.
Thanks for another great first draft! ✨✨
Same as the other PRs, let's work on reviewing your work in detail and catching mistakes. ✌🏽This PR specifically had more punctuation errors, showing a lack of proper review. (i.e., You had dangling commas instead of colons for introducing code snippets.)
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
…bsite into docs-payload-schema
fmvilas
reviewed
Nov 22, 2023
thulieblack
moved this from Community PR under Review 🧐
to Done 🚀
in AsyncAPI Docs Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: #1515