Skip to content

[BUG] React Hook dependency warnings in multiple components #4617

@Sam-61s

Description

@Sam-61s

Describe the bug.

Multiple components across the website have ESLint react-hooks/exhaustive-deps warnings. These warnings indicate missing or unnecessary dependencies in React hooks, which can lead to stale closure bugs and unexpected component behavior.

Running npm run lint reveals 8 warnings across 7 component files where useEffect and useMemo hooks don't properly declare their dependencies.

Affected components:

  • components/AlgoliaSearch.tsx (line 318)
  • components/campaigns/AnnouncementHero.tsx (line 24)
  • components/dashboard/table/Filters.tsx (line 42)
  • components/navigation/DocsNav.tsx (line 79)
  • components/navigation/Filter.tsx (lines 35, 39)
  • components/tools/ToolsCard.tsx (line 35)
  • components/tools/ToolsDashboard.tsx (line 166)

Expected behavior

All React hooks should properly declare their dependencies in their dependency arrays.

Expected output:
npm run lint
✔ No ESLint warnings

Screenshots

The Problem:

Image

The Solution:
Image

How to Reproduce

  1. Clone the repository
  2. npm install
  3. npm run lint
  4. Observe React Hook dependency warnings

Current output:
./components/AlgoliaSearch.tsx
318:6 Warning: React Hook useEffect has missing dependencies...

./components/campaigns/AnnouncementHero.tsx
24:106 Warning: React Hook useMemo has an unnecessary dependency...

./components/dashboard/table/Filters.tsx
42:6 Warning: React Hook useEffect has a missing dependency...

./components/navigation/DocsNav.tsx
79:6 Warning: React Hook useEffect has a missing dependency...

./components/navigation/Filter.tsx
35:6 Warning: React Hook useEffect has missing dependencies...
39:6 Warning: React Hook useEffect has missing dependencies...

./components/tools/ToolsCard.tsx
35:6 Warning: React Hook useEffect has an unnecessary dependency...

./components/tools/ToolsDashboard.tsx
166:6 Warning: React Hook useEffect has a missing dependency...

🖥️ Device Information [optional]

  • Operating System (OS):: Linux (WSL2), Windows, macOS (affects all)
  • Browser: N/A (this is a build-time linting issue)
  • Browser Version:

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions