-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
Describe the bug.
Multiple components across the website have ESLint react-hooks/exhaustive-deps warnings. These warnings indicate missing or unnecessary dependencies in React hooks, which can lead to stale closure bugs and unexpected component behavior.
Running npm run lint reveals 8 warnings across 7 component files where useEffect and useMemo hooks don't properly declare their dependencies.
Affected components:
- components/AlgoliaSearch.tsx (line 318)
- components/campaigns/AnnouncementHero.tsx (line 24)
- components/dashboard/table/Filters.tsx (line 42)
- components/navigation/DocsNav.tsx (line 79)
- components/navigation/Filter.tsx (lines 35, 39)
- components/tools/ToolsCard.tsx (line 35)
- components/tools/ToolsDashboard.tsx (line 166)
Expected behavior
All React hooks should properly declare their dependencies in their dependency arrays.
Expected output:
npm run lint
✔ No ESLint warnings
Screenshots
❌ The Problem:
How to Reproduce
- Clone the repository
npm installnpm run lint- Observe React Hook dependency warnings
Current output:
./components/AlgoliaSearch.tsx
318:6 Warning: React Hook useEffect has missing dependencies...
./components/campaigns/AnnouncementHero.tsx
24:106 Warning: React Hook useMemo has an unnecessary dependency...
./components/dashboard/table/Filters.tsx
42:6 Warning: React Hook useEffect has a missing dependency...
./components/navigation/DocsNav.tsx
79:6 Warning: React Hook useEffect has a missing dependency...
./components/navigation/Filter.tsx
35:6 Warning: React Hook useEffect has missing dependencies...
39:6 Warning: React Hook useEffect has missing dependencies...
./components/tools/ToolsCard.tsx
35:6 Warning: React Hook useEffect has an unnecessary dependency...
./components/tools/ToolsDashboard.tsx
166:6 Warning: React Hook useEffect has a missing dependency...
🖥️ Device Information [optional]
- Operating System (OS):: Linux (WSL2), Windows, macOS (affects all)
- Browser: N/A (this is a build-time linting issue)
- Browser Version:
👀 Have you checked for similar open issues?
- I checked and didn't find similar issue
🏢 Have you read the Contributing Guidelines?
- I have read the Contributing Guidelines
Are you willing to work on this issue ?
Yes I am willing to submit a PR!
