fix: support BASE_URL for studio docker builds #1208
Conversation
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
|
I think this PR is ready for review, thanks 🏓 |
antoineauger
requested review from
Amzani,
KhudaDad414,
Shurtu-gal,
asyncapi-bot-eve and
magicmatatjahu
as code owners
|
@magicmatatjahu Do you think this PR makes sense? In the meantime, we built locally our own |
antoineauger
force-pushed
the
fix/studio-docker-build
branch
from
76caca0 to
49f070a
Compare
github-project-automation
bot
moved this from Backlog
to In progress
in Studio - Kanban
antoineauger
changed the title
antoineauger
force-pushed
the
fix/studio-docker-build
branch
from
72a9470 to
6bf38e5
Compare
antoineauger
force-pushed
the
fix/studio-docker-build
branch
from
6bf38e5 to
1e39788
Compare
princerajpoot20
left a comment
princerajpoot20
left a comment
There was a problem hiding this comment.
Good work @antoineauger . Just left a minor suggestion.
antoineauger
force-pushed
the
fix/studio-docker-build
branch
from
55c23e7 to
d32e9d9
Compare
antoineauger
force-pushed
the
fix/studio-docker-build
branch
from
d32e9d9 to
2fefe53
Compare
|
|
@princerajpoot20 I cleaned up the unnecessary changes, this should be ready now 👌🏻 |
princerajpoot20
left a comment
princerajpoot20
left a comment
There was a problem hiding this comment.
LGTM! Good work @antoineauger
|
@Shurtu-gal PTAL |
Shurtu-gal
left a comment
Shurtu-gal
left a comment
There was a problem hiding this comment.
Lgtm @princerajpoot20
Thanks for the awesome work @antoineauger
|
/rtm |
4 participants
Description
The support for the
BASE_URLenvironment variable introduced within #248 was sadly broken when the project migrated to Next.JS.This PR is composed of two commits:
logo-studio.svgwas not loading, even when running without aBASE_URL- see below)basePathNext.JS config option as documented within the official doc.Related issue(s)
Related to #249
logo-studio.svg not loading due to nginx file permissions
PR test
I built locally the image and deployed it on our k8s environment with
BASE_URL=/tools/asyncapi-studio/cc @fgreinacher
🛠️ with ❤️ by Siemens