Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly store already converted schemas while parsing AsyncApi schema (#548) #554

Merged
merged 2 commits into from
Jan 4, 2022
Merged

fix: correctly store already converted schemas while parsing AsyncApi schema (#548) #554

merged 2 commits into from
Jan 4, 2022

Conversation

kamko
Copy link
Contributor

@kamko kamko commented Jan 3, 2022

Description
Simple change - correctly save converted schemas in alreadyIteratedSchemas

Related issue(s)
Fixes #548

@coveralls
Copy link

coveralls commented Jan 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1653735839

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 93.2%
Totals Coverage Status
Change from base Build 1649786592: -0.002%
Covered Lines: 2293
Relevant Lines: 2343
💛 - Coveralls

@kamko kamko changed the title fix: AsyncAPIInputProcessor should handle multiple references to the same schema (#548) fix: correctly store already converted schemas while parsing AsyncApi schema (#548) Jan 3, 2022
@kamko kamko force-pushed the 548/AsyncAPIInputProcessor_incorrectly_stores_encountered_schemas branch from 0697efb to b04532e Compare January 4, 2022 00:05
jonaslagoni
jonaslagoni approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kamko!

@jonaslagoni
Copy link
Member

/rtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni merged commit f067637 into asyncapi:master Jan 4, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.39.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
ready-to-merge released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncAPIInputProcessor incorrectly stores encountered schemas
4 participants
@kamko @coveralls @jonaslagoni @asyncapi-bot