Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): add option to modify array type for C# in playground #1183

Merged
merged 2 commits into from
Mar 23, 2023
Merged

chore(website): add option to modify array type for C# in playground #1183

merged 2 commits into from
Mar 23, 2023

Conversation

prayutsu
Copy link
Contributor

Description

  • Added option in the playground to select collection type.

Related issue(s)

Resolves #1180

@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited
Loading

✅ Deploy Preview for modelina ready!

Name Link
🔨 Latest commit be06c62
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/641c04965a2f7600084f4ae7
😎 Deploy Preview https://deploy-preview-1183--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prayutsu
Copy link
Contributor Author

@jonaslagoni PTAL

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4498235823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.404%
Totals Coverage Status
Change from base Build 4482013626: 0.0%
Covered Lines: 4732
Relevant Lines: 4991
💛 - Coveralls

jonaslagoni
jonaslagoni approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 4f5536e into asyncapi:master Mar 23, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
ready-to-merge released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add different array types in the Playground
4 participants
@prayutsu @coveralls @jonaslagoni @asyncapi-bot