fix: upgrade simple-git to support Node 24+#2005
fix: upgrade simple-git to support Node 24+#2005divyarathodgit wants to merge 2 commits intoasyncapi:masterfrom
Conversation
Upgrades simple-git to resolve 'ENOENT: node:buffer' errors caused by internal API changes in newer Node.js versions. Verified with tests passing on Node 24.
divyarathodgit
requested review from
asyncapi-bot-eve,
derberg,
jonaslagoni and
magicmatatjahu
as code owners
|
What reviewer looks at during PR reviewThe following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.
|
📝 WalkthroughWalkthroughThe simple-git dependency has been updated from version ^3.3.0 to ^3.30.0 in apps/generator/package.json, and the same dependency version has been added to the root package.json dependencies section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 49-51: Remove the redundant "simple-git" dependency from the root
package.json by deleting the "simple-git": "^3.30.0" entry from the
"dependencies" object (ensure the JSON remains valid—remove the trailing comma
if needed or delete the whole empty "dependencies" block if nothing else
remains); keep runtime dependency management in apps/generator/package.json
which already declares simple-git.
| "dependencies": { | ||
| "simple-git": "^3.30.0" | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, check if apps/generator/package.json declares simple-git
cat apps/generator/package.json | grep -A 10 -B 2 "simple-git"Repository: asyncapi/generator
Length of output: 411
🏁 Script executed:
# Run the verification script to check if simple-git is used directly at root level (outside workspace packages)
rg -n "simple-git" --glob '!node_modules' --glob '!package-lock.json' --glob '!apps/**' --glob '!packages/**'Repository: asyncapi/generator
Length of output: 105
🏁 Script executed:
# Check the root package.json to understand workspace configuration and current state
cat package.json | head -60Repository: asyncapi/generator
Length of output: 2381
🏁 Script executed:
# Look for any root-level scripts or configurations that might use simple-git
rg -n "require.*simple-git|import.*simple-git" --glob '!node_modules' --glob '!apps/**' --glob '!packages/**'Repository: asyncapi/generator
Length of output: 44
Remove unnecessary simple-git dependency from root package.json.
apps/generator/package.json already declares simple-git as its own dependency, and there is no usage of simple-git at the root level. Adding it to the root's dependencies is redundant in a workspace monorepo. Workspace packages should manage their own runtime dependencies independently. Remove this entry to keep the root manifest clean.
Suggested diff
- ],
- "dependencies": {
- "simple-git": "^3.30.0"
- }
-}
+ ]
+}🤖 Prompt for AI Agents
In `@package.json` around lines 49 - 51, Remove the redundant "simple-git"
dependency from the root package.json by deleting the "simple-git": "^3.30.0"
entry from the "dependencies" object (ensure the JSON remains valid—remove the
trailing comma if needed or delete the whole empty "dependencies" block if
nothing else remains); keep runtime dependency management in
apps/generator/package.json which already declares simple-git.
|
3 participants
This PR upgrades simple-git to the latest version to resolve compatibility issues with Node.js v24 (and other recent versions).
The Problem:
Older versions of simple-git trigger an ENOENT: no such file or directory, open 'node:buffer' error when running tests on modern Node environments due to changes in how internal modules are resolved.
The Fix:
Upgraded simple-git dependency in root and apps/generator.
Regenerated package-lock.json to reflect the version bump (minimal diff).
Verification:
npm run test:unit passes successfully on Node v24.13.0.
Summary by CodeRabbit