-
-
Notifications
You must be signed in to change notification settings - Fork 173
ci: website board governance - yaml to json conversion #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: aminoxix <aminoxix@duck.com>
|
Caution Review failedThe pull request is closed. WalkthroughThe workflow for updating the website board governance was modified to convert a YAML file of board members into JSON, prepend auto-generated comments to both formats, and update subsequent steps to use the JSON file. Minor wording adjustments were made to autogenerated comments and PR body text. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant YAML File
participant Python Script
participant JSON File
participant Website Repo
Workflow->>YAML File: Access TSC_BOARD_MEMBERS.yaml
Workflow->>Python Script: Run YAML-to-JSON conversion
Python Script->>JSON File: Output TSC_BOARD_MEMBERS.json
Workflow->>JSON File: Prepend auto-generated comment
Workflow->>Website Repo: Copy and commit JSON file
Workflow->>Website Repo: Create PR to update board members
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/update-website-board-governance.yml(3 hunks)
🔇 Additional comments (5)
.github/workflows/update-website-board-governance.yml (5)
48-49: Consistent “auto-generated” comment in YAML
The updated wording is clear and matches the JSON step comment.
56-59: Consistent “auto-generated” comment in JSON
The JSON prepend mirrors the YAML step and uses the same wording – nice and consistent.
74-74: Copying JSON into website config
Thiscpcorrectly brings the generated JSON intowebsite/config.
83-83: Renamed PR step is clearer
The new step name “Create PR to website repository” aligns with its action.
106-106: Consistent phrasing in community PR body
Swapping “autogenerated” for “auto-generated” matches the other steps and maintains consistency.
Signed-off-by: aminoxix <aminoxix@duck.com>
|
/rtm |
Description
TSC_BOARD_MEMBERS.yamlto JSON format before commit & push to the website repositoryRelated issue(s)
related ref: asyncapi/website#4127
Summary by CodeRabbit