feat(studio): add --no-browser flag & fix standalone build support #2002
+196
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshanCode2005
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
--no-browserflag for thestart studiocommand, allowing users to start the studio without automatically opening a browser window.Additionally, it fixes a critical issue where the Studio server would hang or fail to load correctly because the CLI was not properly handling the Next.js "standalone" build output used by newer versions of
@asyncapi/studio.Changes
--no-browser(alias-Bis preserved but mapped to this new flag) tostart studio.--no-browseris used, the console output now shows a neutral "Studio is running at..." message instead of the imperative "Open this URL..." instruction.Studio.tsto support the Next.js standalone server/publicand/static) to the standalone build directory to prevent 404 errors.Testing
asyncapi start studio --no-browser-> Server starts, no browser opens, neutral log message shown.asyncapi start studio-> Server starts, browser opens automatically.Related Issues
Closes #2001
Video Demo
https://drive.google.com/file/d/1xnaiEKIIHBIx5dS1Eydkj_QdJdpQoYRh/view?usp=sharing